UW Improvements#290
Conversation
…initially, even without Twilio credentials
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive error handling to async operations in two critical areas: the scheduled morning tasks and user authentication flow. The changes ensure that failures in individual operations don't cause cascading failures and are properly logged for debugging.
- Added
.catch()handlers with logging to all promises ineveryMorning()method - Enhanced email address extraction to support SSO credential claims (
upnandunique_name) - Added validation using Zod schema for email address parsing
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| functions/src/services/trigger/triggerService.ts | Added individual error handlers with logging to all async operations in Promise.all |
| functions/src/functions/blocking.ts | Enhanced email extraction logic to handle SSO credentials and added validation with error handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
==========================================
- Coverage 82.43% 81.67% -0.75%
==========================================
Files 91 91
Lines 3607 3627 +20
Branches 894 897 +3
==========================================
- Hits 2973 2962 -11
- Misses 600 631 +31
Partials 34 34
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
PSchmiedmayer
left a comment
There was a problem hiding this comment.
Looks great; thank you @pauljohanneskraft 🚀
UW Improvements
♻️ Current situation & Problem
We have encountered a couple of issues when setting up these functions in a different environment (UW). During troubleshooting, we found a couple of small improvements and fixes and want to bring them to the original repository as well.
⚙️ Release Notes
event.data.emailor from the provider's claims of the credential.Code of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: