Add float conversion warning #139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The float conversion warning which is raised when a floating point number is truncated to an integer can catch errors (e.g. in #138 I passed a coordinate (double) to a function taking indices (int) by accident but no warning was raised). This warning is therefore added. Warnings arising as a result are fixed with a
static_cast.Several of the warnings are associated with expressions like
int powerOf2 = pow(2, n)these are changed to use bit arithmetic (int powerOf2 = 1 << n) with an explanatory comment as this avoids the need for doubles and requires fewer FLOPs.Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
Checks by code reviewer(s):