Skip to content

Drop now-invalid allow-reresolve input from downgrade workflow(s)#504

Merged
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:drop-allow-reresolve-input
Jun 7, 2026
Merged

Drop now-invalid allow-reresolve input from downgrade workflow(s)#504
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:drop-allow-reresolve-input

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Contributor

What

Remove the now-invalid allow-reresolve: input from the downgrade workflow(s).

The centralized SciML/.github downgrade workflows (downgrade.yml and
sublibrary-downgrade.yml) are being changed to always use
allow_reresolve: false and to drop the allow-reresolve workflow_call
input entirely (see SciML/.github#71). Once that merges and @v1 is retagged,
any caller still passing allow-reresolve: would fail with an invalid-input
error. This PR removes that line so this repo keeps working.---

Please ignore until reviewed by @ChrisRackauckas.

🤖 Generated with Claude Code

Co-Authored-By: Chris Rackauckas accounts@chrisrackauckas.com
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

The reusable SciML/.github downgrade workflows now always use
allow_reresolve: false and no longer accept an allow-reresolve input
(see SciML/.github#71). Remove the now-invalid input so this caller keeps
working once @v1 is retagged.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review June 7, 2026 12:11
@ChrisRackauckas ChrisRackauckas merged commit 074eeb8 into SciML:master Jun 7, 2026
7 of 10 checks passed
@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results (Julia v1.11)

Time benchmarks
master 79b3f86... master / 79b3f86...
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK2() 0.595 ± 0.009 s 0.595 ± 0.0078 s 1 ± 0.02
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK3() 12.2 ± 0.26 ms 12.2 ± 0.29 ms 0.996 ± 0.032
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK4() 2.66 ± 0.072 ms 2.64 ± 0.074 ms 1.01 ± 0.039
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK5() 3.22 ± 0.093 ms 3.23 ± 0.085 ms 0.996 ± 0.039
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK6() 1.57 ± 0.048 ms 1.57 ± 0.061 ms 0.997 ± 0.049
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = false) 1.54 ± 0.066 ms 1.53 ± 0.072 ms 1 ± 0.064
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = true) 3.16 ± 0.12 ms 3.13 ± 0.11 ms 1.01 ± 0.054
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.0388 ± 0.0024 s 0.0383 ± 0.0026 s 1.01 ± 0.093
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = true) 0.0599 ± 0.002 s 0.0585 ± 0.0019 s 1.02 ± 0.047
Simple Pendulum/IIP/Shooting(Tsit5()) 0.173 ± 0.072 ms 0.174 ± 0.071 ms 0.993 ± 0.58
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK2() 0.737 ± 0.0046 s 0.738 ± 0.0075 s 1 ± 0.012
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK3() 17.5 ± 4.5 ms 15.6 ± 4.6 ms 1.12 ± 0.44
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK4() 3.2 ± 0.13 ms 3.17 ± 0.11 ms 1.01 ± 0.053
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK5() 3.84 ± 0.22 ms 3.88 ± 0.2 ms 0.99 ± 0.077
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK6() 1.85 ± 0.11 ms 1.83 ± 0.11 ms 1.01 ± 0.085
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = false) 3.24 ± 0.59 ms 3.26 ± 0.67 ms 0.994 ± 0.27
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = true) 6.57 ± 5.4 ms 6.38 ± 5 ms 1.03 ± 1.2
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.082 ± 0.0039 s 0.081 ± 0.004 s 1.01 ± 0.069
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = true) 0.128 ± 0.0053 s 0.128 ± 0.0057 s 0.999 ± 0.061
Simple Pendulum/OOP/Shooting(Tsit5()) 0.591 ± 0.032 ms 0.587 ± 0.034 ms 1.01 ± 0.08
time_to_load 6.62 ± 0.047 s 6.63 ± 0.061 s 0.997 ± 0.012
Memory benchmarks
master 79b3f86... master / 79b3f86...
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK2() 0.389 M allocs: 0.0442 GB 0.389 M allocs: 0.0442 GB 1
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK3() 0.0436 M allocs: 4.85 MB 0.0436 M allocs: 4.85 MB 1
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK4() 15.7 k allocs: 1.63 MB 15.7 k allocs: 1.63 MB 1
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK5() 22.1 k allocs: 2.02 MB 22.1 k allocs: 2.02 MB 1
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK6() 12.8 k allocs: 1.04 MB 12.8 k allocs: 1.04 MB 1
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = false) 25.4 k allocs: 1.82 MB 25.4 k allocs: 1.82 MB 1
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = true) 0.0488 M allocs: 3.36 MB 0.0488 M allocs: 3.36 MB 1
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.552 M allocs: 0.0534 GB 0.552 M allocs: 0.0534 GB 1
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = true) 0.832 M allocs: 0.0777 GB 0.832 M allocs: 0.0777 GB 1
Simple Pendulum/IIP/Shooting(Tsit5()) 4.62 k allocs: 0.223 MB 4.62 k allocs: 0.223 MB 1
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK2() 0.89 M allocs: 0.984 GB 0.89 M allocs: 0.984 GB 1
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK3() 0.0932 M allocs: 24.7 MB 0.0932 M allocs: 24.7 MB 1
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK4() 0.0324 M allocs: 3.94 MB 0.0324 M allocs: 3.94 MB 1
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK5() 0.045 M allocs: 4.97 MB 0.045 M allocs: 4.97 MB 1
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK6() 25.3 k allocs: 2.16 MB 25.3 k allocs: 2.16 MB 1
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = false) 0.142 M allocs: 10.2 MB 0.142 M allocs: 10.2 MB 1
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = true) 0.265 M allocs: 18.7 MB 0.265 M allocs: 18.7 MB 1
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = false) 2.52 M allocs: 0.279 GB 2.52 M allocs: 0.279 GB 1
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = true) 3.82 M allocs: 0.404 GB 3.82 M allocs: 0.404 GB 1
Simple Pendulum/OOP/Shooting(Tsit5()) 0.0373 M allocs: 1.69 MB 0.0373 M allocs: 1.69 MB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants