Use SciMLTesting v1.1.0 run_tests harness#1487
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Conversation
Replace the hand-written `GROUP` if-ladder in `test/runtests.jl` with a single declarative `run_tests` call from SciMLTesting v1.1.0. The six functional groups (Modeling, Simulation, Hybrid, Misc, Spatial, Extensions) are passed as `groups` entries, and a curated `all = [...]` reproduces the original `All` membership exactly: All runs all six groups, in the original order. There is no QA group in this repo. The Extensions group keeps its isolated `test/extensions` env via the `env` kwarg (which performs the same Pkg.activate / develop(root) / instantiate that the old `activate_extensions_env` did). This is a behavior-equivalent refactor: the set of testsets run under each GROUP value (including bare/All) is identical before and after, verified with a dispatch dry-run. Project.toml: add SciMLTesting (09d9d899-5365-40a9-917a-5f67fddea283) to [extras], [compat] SciMLTesting = "1", and the test target; drop Pkg from the test deps (only the old harness used it; run_tests bundles Pkg). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the hand-written
GROUPif-ladder intest/runtests.jlwith a single declarativerun_testscall from SciMLTesting v1.1.0.What changed
Modeling,Simulation,Hybrid,Misc,Spatial,Extensions) are passed asgroupsentries.all = ["Modeling", "Simulation", "Hybrid", "Misc", "Spatial", "Extensions"]reproduces the originalAllmembership exactly: bare/Allruns all six groups in the original order. This repo has no QA group.Extensionsgroup keeps its isolatedtest/extensionsenvironment via theenvkwarg, which performs the samePkg.activate/Pkg.develop(repo root)/Pkg.instantiatethat the oldactivate_extensions_env()helper did.Behavior equivalence
This is a behavior-equivalent refactor — no test assertions or logic changed, and the set of testsets run under each
GROUPvalue (including bare/All) is identical before and after. Verified with a dispatch dry-run:AllModeling/Simulation/Hybrid/Misc/Spatial/ExtensionsProject.toml
SciMLTesting(09d9d899-5365-40a9-917a-5f67fddea283) to[extras],[compat] SciMLTesting = "1", and the test target.Pkgfrom the test deps — only the old harness used it;run_testsbundlesPkg.Ignore until reviewed by @ChrisRackauckas.