Use SciMLTesting v1.2 (folder-based run_tests)#74
Merged
ChrisRackauckas merged 1 commit intoJun 14, 2026
Conversation
b84edb5 to
5f7fcc4
Compare
Contributor
Author
|
Force-pushed the corrected v1.1.0 conversion over the v1.0.0 first pass. The first pass had the QA body in |
Replace the hand-written GROUP dispatch in test/runtests.jl with the SciMLTesting v1.2 folder-discovery model (`using SciMLTesting; run_tests()`). - Core = top-level test/*.jl (the 8 existing core test files), main test env. - QA = test/qa/ with its existing per-group Project.toml sub-env. - Dormant, never-run files (network_properties.jl, networksummary.jl, test_networks.jl) moved to test/shared/ so folder-discovery does not pick them up as Core (behavior-preserving). - Root [extras]/[targets].test: add SciMLTesting, drop Pkg (the v1.2 harness owns all Pkg operations; no test/*.jl uses Pkg directly). - test/qa/Project.toml: add SciMLTesting + SafeTestsets, drop Pkg. - test/test_groups.toml unchanged. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
5f7fcc4 to
2f2dcf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the test suite to the SciMLTesting v1.2 folder-discovery model.
test/runtests.jlis now:Layout:
test/*.jlfiles (ACR, concordancehelpers, deficiencyone, lp_utils, network_translation, persistence, siphons, specificscc), run in the main test env.test/qa/with its existing per-groupProject.tomlsub-env (Aqua + JET),Pkg.develop-ing the repo root automatically.network_properties.jl,networksummary.jl, andtest_networks.jlare moved totest/shared/so folder-discovery (Core = all top-level*.jl) does not start running them. They were not run by anyGROUPbefore; this keeps the discovered Core set identical.Dep changes:
[extras]/[targets].test: addSciMLTesting; dropPkg(notest/*.jlusesPkgdirectly — the v1.2 harness owns allPkgoperations).test/qa/Project.toml: addSciMLTesting+SafeTestsets; dropPkg.test/test_groups.tomlunchanged.Verified statically: every
Project.tomlandtest_groups.tomlparses;runtests.jl,qa.jl, and the moved files parse; and the v1.2 folder dispatcher discovers exactly the same per-group file set as the previousGROUPdispatch (Core = the 8 files, QA = qa.jl in the sub-env, All = Core).Ignore until reviewed by @ChrisRackauckas.