Skip to content

Use SciMLTesting v1.2 (folder-based run_tests)#74

Merged
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:sciml-testing-rollout
Jun 14, 2026
Merged

Use SciMLTesting v1.2 (folder-based run_tests)#74
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:sciml-testing-rollout

Conversation

@ChrisRackauckas-Claude

@ChrisRackauckas-Claude ChrisRackauckas-Claude commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Converts the test suite to the SciMLTesting v1.2 folder-discovery model.

test/runtests.jl is now:

using SciMLTesting
run_tests()

Layout:

  • Core = the existing top-level test/*.jl files (ACR, concordancehelpers, deficiencyone, lp_utils, network_translation, persistence, siphons, specificscc), run in the main test env.
  • QA = test/qa/ with its existing per-group Project.toml sub-env (Aqua + JET), Pkg.develop-ing the repo root automatically.
  • The never-run helper files network_properties.jl, networksummary.jl, and test_networks.jl are moved to test/shared/ so folder-discovery (Core = all top-level *.jl) does not start running them. They were not run by any GROUP before; this keeps the discovered Core set identical.

Dep changes:

  • Root [extras]/[targets].test: add SciMLTesting; drop Pkg (no test/*.jl uses Pkg directly — the v1.2 harness owns all Pkg operations).
  • test/qa/Project.toml: add SciMLTesting + SafeTestsets; drop Pkg.
  • test/test_groups.toml unchanged.

Verified statically: every Project.toml and test_groups.toml parses; runtests.jl, qa.jl, and the moved files parse; and the v1.2 folder dispatcher discovers exactly the same per-group file set as the previous GROUP dispatch (Core = the 8 files, QA = qa.jl in the sub-env, All = Core).

Ignore until reviewed by @ChrisRackauckas.

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Contributor Author

Force-pushed the corrected v1.1.0 conversion over the v1.0.0 first pass. The first pass had the QA body in groups (a reserved key), so GROUP=QA would have errored before reaching the groups table. Corrected by moving QA to the dedicated qa= kwarg and setting all = ["Core"] so bare/All runs only Core (never QA), matching the original dispatcher. Verified the All/Core/QA routing with a dispatch dry-run.

@ChrisRackauckas-Claude ChrisRackauckas-Claude changed the title Use SciMLTesting v1.0.0 (run_tests harness) Use SciMLTesting v1.1.0 run_tests harness Jun 14, 2026
Replace the hand-written GROUP dispatch in test/runtests.jl with the
SciMLTesting v1.2 folder-discovery model (`using SciMLTesting; run_tests()`).

- Core = top-level test/*.jl (the 8 existing core test files), main test env.
- QA = test/qa/ with its existing per-group Project.toml sub-env.
- Dormant, never-run files (network_properties.jl, networksummary.jl,
  test_networks.jl) moved to test/shared/ so folder-discovery does not pick
  them up as Core (behavior-preserving).
- Root [extras]/[targets].test: add SciMLTesting, drop Pkg (the v1.2 harness
  owns all Pkg operations; no test/*.jl uses Pkg directly).
- test/qa/Project.toml: add SciMLTesting + SafeTestsets, drop Pkg.
- test/test_groups.toml unchanged.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ChrisRackauckas-Claude ChrisRackauckas-Claude changed the title Use SciMLTesting v1.1.0 run_tests harness Use SciMLTesting v1.2 (folder-based run_tests) Jun 14, 2026
@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review June 14, 2026 23:54
@ChrisRackauckas ChrisRackauckas merged commit 648fa86 into SciML:main Jun 14, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants