Add ExplicitImports.jl tests to ensure import hygiene#44
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
Add ExplicitImports.jl tests to ensure import hygiene#44ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
- Added test suite to verify no implicit or stale imports - Moved ExplicitImports from runtime dependency to test dependency - All tests pass successfully The package currently has no import issues (clean bill of health from ExplicitImports.jl). This test ensures future code additions maintain proper explicit imports. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Analysis Results
The ExplicitImports.jl analysis shows:
Since the package currently contains only an empty module, there are no import issues to fix. However, these tests will ensure that future code additions maintain proper explicit imports hygiene.
Changes
test/runtests.jl: Added ExplicitImports test suite with checks for:
check_no_implicit_imports(ColPrac)check_no_stale_explicit_imports(ColPrac)Project.toml:
[deps]to[extras](test-only dependency)[targets]test sectionTest Results
All tests pass successfully:
This ensures the package follows SciML best practices for explicit imports and will catch any import hygiene issues in future development.
cc @ChrisRackauckas
🤖 Generated with Claude Code