Use SciMLTesting v1.2 (explicit-args run_tests)#621
Merged
ChrisRackauckas merged 1 commit intoJun 14, 2026
Conversation
Convert the root test/runtests.jl to drive SciMLTesting v1.2's run_tests.
As a monorepo (lib/DataDriven{DMD,Lux,SR,Sparse}) with a curated `All`
(only Core) and local sublibrary routing, it uses the explicit-args form
(not folder-discovery, which cannot express either): run_tests is called
with the 7 Core @safetestsets as `core`, the nopre JET group as an
env-bearing `groups` entry, and `all = ["Core"]`. detect_sublibrary_group
(from SciMLTesting) replaces the hand-rolled helper; the <1.11 transitive
[sources] develop walk + Pkg.test(sublib, coverage=true) sublib pre-step
is kept verbatim. SciMLTesting added to the root test deps and to
test/nopre/Project.toml; Pkg retained (sublib pre-step uses it).
test/test_groups.toml unchanged.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert the root
test/runtests.jlto drive SciMLTesting v1.2'srun_tests.This is a monorepo (
lib/DataDriven{DMD,Lux,SR,Sparse}), so it uses the explicit-args form ofrun_tests(not folder-discovery), matching the OrdinaryDiffEq.jl / RecursiveArrayTools.jl pattern. Folder-discovery cannot express this repo's shape:nopregroup is curated out ofAll(Allruns onlyCore), andGROUP(e.g.DataDrivenDMD,DataDrivenSparse_QA) toPkg.testoflib/<sublib>for local runs (CI tests sublibs viaSublibraryCI.yml).Both require explicit-args mode, whose
lib_dir/allknobs the folder-discovery branch returns before reaching.Changes:
detect_sublibrary_group(from SciMLTesting) replaces the hand-rolled_detect_sublibrary_group; the<1.11transitive[sources]develop walk +Pkg.test(sublib, coverage=true)sublib pre-step is kept verbatim.run_tests(; core = <7 Core @safetestsets>, groups = Dict("nopre" => (; env = test/nopre, body = JET)), all = ["Core"]).SciMLTestingadded to the root test deps and totest/nopre/Project.toml(withSafeTestsets+Test).Pkgis retained (still used by the sublib pre-step).test/test_groups.tomlis unchanged.Behavior-preserving: the exact set of tests run under each
GROUPvalue (All/Core/Downstream-> Core;nopre-> JET; sublib names -> sublibPkg.test) is unchanged. Verified by driving the v1.2.0run_testsdispatcher over everyGROUPvalue.Ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code