The autoregulation `@example` block in
docs/src/libs/datadrivensparse/example_04.md failed the docs build with
`UndefVarError: @mtkmodel not defined`. ModelingToolkit v10/v11 removed the
`@mtkmodel` macro entirely (it is no longer defined or exported; the
example had already been partially ported, using the v10 `@mtkcompile`).
Replace the `@mtkmodel`/`@mtkcompile` model definition with the MTK v11
direct `System` construction (`@parameters`/`@variables`/`System(eqs, t)` +
`mtkcompile`), which yields the same `sys.x` array variables the rest of
the example consumes. Also drop the now-unused `NoSpecialize` import and
the `ODEProblem{true, NoSpecialize}` type parameters (plain
`ODEProblem(sys, [], tspan)` is the v11 form).
Verified locally on Julia 1.12 (ModelingToolkit v11.26.8): a focused
Documenter build of the example_04 page runs every `@example` block with
no `:example_block` errors (makedocs completes with VERIFY_MAKEDOCS_OK).
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Problem
Both
tests / QAjobs (julia 1 and julia lts) fail onmasterat test startup with:Root cause
SciMLTesting 1.2's
run_testsroutes the reserved"QA"group through a dedicatedqa=keyword argument, not through thegroupsDict. Inrun_tests, theelseif group == "QA"branch is evaluated beforegroupsis consulted, and it throws whenqa === nothing:test/runtests.jldeclared the QA spec insidegroups = Dict("QA" => ...)and leftqaunset, so the dispatch errored before it ever reached thegroupstable. This was introduced in the v1.2 folder-model conversion (#619 normalized the group into canonical QA, but the wiring was still viagroups).The reusable CI workflow (
grouped-tests.yml@v1) readstest/test_groups.toml, which correctly declares theQAgroup on lts/1, and dispatchesGROUP=QAtoPkg.test. The workflow andtest_groups.tomlare correct; onlyruntests.jlwas miswired.Fix
Move the QA spec from
groups = Dict("QA" => (; env, body))to the dedicatedqa = (; env, body)keyword, matching the SciMLTesting v1.2 explicit-args API. No other change.Verification (local)
Against SciMLTesting 1.2.0 on Julia 1.10:
groupswithGROUP=QAthrows the exactArgumentError: GROUP="QA" was requested but no qa body was provided.qa = (; ...),GROUP=QAreaches the QA body (new QA body reached), andGROUP=Corestill reaches the core body — no error.Runic.format_stringconfirmstest/runtests.jlis already correctly formatted (FormatCheck clean).Please ignore until reviewed by @ChrisRackauckas.