refactor: migrate Curvefit from Optim.jl to CurveFit.jl#506
Open
sathvikbhagavan wants to merge 8 commits into
Open
refactor: migrate Curvefit from Optim.jl to CurveFit.jl#506sathvikbhagavan wants to merge 8 commits into
sathvikbhagavan wants to merge 8 commits into
Conversation
sathvikbhagavan
force-pushed
the
sb/curvefit
branch
from
2022139 to
58b6f66
Compare
Member
Author
|
Hi @ChrisRackauckas, how do we pass bounds using CurveFit? CurveFitProblems https://github.com/SciML/CurveFit.jl/blob/master/src/common_interface.jl#L49 does not take any bounds? |
Member
Member
Author
|
Hi @ChrisRackauckas, this PR is ready for review |
|
|
||
| [extensions] | ||
| DataInterpolationsChainRulesCoreExt = "ChainRulesCore" | ||
| DataInterpolationsOptimExt = "Optim" |
Member
There was a problem hiding this comment.
deleting this would be breaking though
Member
Author
There was a problem hiding this comment.
hmm, so should I keep both like add a new one with CurveFit?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #505