Add matrix support for AkimaInterpolation#521
Open
mrarat wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
AbstractMatrixinput support forAkimaInterpolation.Previously,
AkimaInterpolation(u, t)only accepted vector-likeu, while the documented interface supports stacked array data where the last dimension corresponds to time. With this change, matrix-valued data can be passed as:For scalar evaluation times, A(t_eval) now returns a vector containing the interpolated value for each row of u.
Changes
Known limitation
This PR intentionally does not fix matrix-valued extrapolation.
The current generic extrapolation code in DataInterpolations uses first(A.u) and last(A.u) to obtain endpoint values. For
matrix-valued u, those return scalar array entries, not the first/last output column. This affects matrix-valued extrapolation more generally, not only Akima.
Because of that, matrix-valued extrapolation and extrapolated derivative/integral behavior should be addressed in a separate PR with a global fix.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional information
AkimaInterpolationconstruction, in-domain evaluation, derivatives, and integrals.