Canonical CI: grouped-tests.yml + root test/test_groups.toml#76
Merged
ChrisRackauckas merged 2 commits intoJun 10, 2026
Merged
Conversation
Convert the root test workflow (Tests.yml) to the canonical SciML/.github grouped-tests.yml@v1 thin caller, with the group x version matrix declared once in test/test_groups.toml. Category B refactor: the inline JET/ExplicitImports/AllocCheck checks (previously bundled in the lowercase "nopre" group) are moved into a GROUP=="QA" group, isolated in test/qa/Project.toml (Aqua-free env via a [sources] path to the package root) with a qa.jl aggregator. Functional tests run under GROUP=="Core" (and "All"). runtests.jl dispatches on the canonical uppercase GROUP values; for QA it activates test/qa, develops the package, instantiates, then includes qa.jl. Matrix mapping (group renamed, per-group version coverage identical): core -> Core on [lts, 1, pre] nopre -> QA on [lts, 1] Benign Project.toml metadata fixes: julia compat already at the 1.10 LTS floor; added [compat] entries for the [extras] deps Pkg, Statistics, Test. test/nopre -> test/qa rename also updated in .github/dependabot.yml. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The using DiffEqFinancial, Statistics, StochasticDiffEq line sat inside the top-level if GROUP == ... block that also uses @testset/@test inline. Julia macro-expands the entire if block as one unit before the in-block using runs, so the macros were undefined (UndefVarError: @testset not defined in Main). Move the functional usings to top level, above const GROUP. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the root test workflow (
.github/workflows/Tests.yml) to the canonical SciMLgrouped-tests.yml@v1thin caller, with the group × version matrix declared once in a roottest/test_groups.toml.on:andconcurrency:are preserved verbatim; the matrix test job is replaced by:No
with:overrides are needed: the package reads the defaultGROUPenv var, has noext/(defaultsrc,extcoverage dirs are fine), needs no apt packages, and uses defaultcheck-bounds/coverage. Linux-only (noosaxis). All other workflows are untouched.Category B refactor (inline QA -> isolated QA group)
The repo previously ran ExplicitImports + JET + AllocCheck bundled in a lowercase
nopregroup. These are moved into a canonicalGROUP=="QA"group:GROUP=="Core"(and"All").test/qa/Project.toml(its tooling deps +Test, with the package pulled in via[sources]path ="../..",julia = "1.10") plus atest/qa/qa.jlaggregator (explicit_imports.jl,jet_tests.jl,alloc_tests.jlmoved fromtest/nopre/).runtests.jldispatches on the canonical uppercase GROUP values; forQAitPkg.activatestest/qa,Pkg.develops the repo root,Pkg.instantiates, then includesqa.jl..github/dependabot.ymlupdated for thetest/nopre->test/qarename.Matrix match (1:1, group renamed, per-group version coverage identical)
OLD inline matrix (version ∈ {1, lts, pre}, group ∈ {core, nopre}, exclude nopre+pre):
NEW (
compute_affected_sublibraries.jl --root-matrixagainst the newtest_groups.toml, verified locally):Emitted set:
(Core,lts) (Core,1) (Core,pre) (QA,lts) (QA,1)— 5 jobs, exactly matching the old 5 (core->Core,nopre->QA), allubuntu-latest.Benign metadata fixes (applied without running Aqua)
[compat] juliaalready at the"1.10"LTS floor — left unchanged.[compat]entries for the[extras]deps missing them:Pkg = "1",Statistics = "1",Test = "1".Verification (static only)
test_groups.toml, rootProject.toml,test/qa/Project.tomlparse via JuliaTOML.Tests.ymlparses as YAML; thin-caller shape confirmed.QA group newly wired; Aqua/JET run in CI — any failures will be triaged in follow-up.
Ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code