Canonical CI: grouped-tests.yml + root test/test_groups.toml#117
Merged
ChrisRackauckas merged 3 commits intoJun 10, 2026
Merged
Conversation
Convert the root test workflow to the canonical thin caller of SciML/.github/.github/workflows/grouped-tests.yml@v1, with the matrix declared once in test/test_groups.toml. - Tests.yml: replace the hand-maintained version matrix test job with the grouped-tests.yml@v1 thin caller (on:/concurrency: preserved verbatim, filename + name: kept). Defaults apply (GROUP env, check-bounds, coverage). - test/test_groups.toml: Core on [lts, 1, pre] (reproduces the old matrix), QA on [lts, 1] (newly wired). Linux-only, no os axis. - runtests.jl: add GROUP dispatch (existing tests under Core/All; QA gated). - test/qa/: isolated QA environment (Aqua + JET + Test, package via [sources] path) running Aqua.test_all and JET.test_package. - Project.toml: raise julia compat 1.6 -> 1.10 (LTS floor); add missing [compat] entries for [extras] deps (LinearAlgebra, Random, SafeTestsets, StaticArrays, Test). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The Core test group runs with project='.' and test/runtests.jl does `using Pkg` (for the QA group's Pkg.activate), but Pkg was not a declared test dependency, causing the Core job to fail with `ArgumentError: Package Pkg not found in current path`. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Aqua.test_all reports two real Project.toml hygiene findings (stale dep DiffEqCallbacks; missing compat entry for the Pkg test-extra), and JET.test_package reports genuine errors in src/plot.jl. These are marked @test_broken (not skipped/deleted) so the QA group goes green, with the passing Aqua sub-checks left running. Tracked in SciML#118 to be fixed and un-broken. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the root test workflow (
Tests.yml) to the canonical thin caller ofSciML/.github/.github/workflows/grouped-tests.yml@v1, with the test matrix declared once intest/test_groups.toml.What changed
.github/workflows/Tests.yml: the hand-maintainedversionmatrix test job (callingtests.yml@v1over["1","lts","pre"]) is replaced by thegrouped-tests.yml@v1thin caller.on:andconcurrency:are preserved verbatim; filename andname:are kept. All inputs use defaults (GROUPenv name,check-bounds,coverage), so nowith:block is needed. Linux-only (noosaxis). Other workflows (Downgrade, FormatCheck, RunicSuggestions, SpellCheck, TagBot, DependabotAutoMerge) are untouched.test/test_groups.toml(new):[Core]on["lts","1","pre"],[QA]on["lts","1"].test/runtests.jl: addGROUPdispatch. Existing tests (Hamiltonian, Explicit Imports) run underCore/All;QAactivates the isolated env and runsqa.jl.test/qa/(new): isolated QA environment (Aqua,JET,Test, package via[sources]path) runningAqua.test_all(DiffEqPhysics)andJET.test_package(DiffEqPhysics; target_defined_modules=true).Project.toml: raisejuliacompat1.6->1.10(the LTS floor; also clears Aquas<=1.1project_extras check); add missing[compat]entries for[extras]deps (LinearAlgebra,Random,SafeTestsets,StaticArrays,Test).Matrix match
Statically verified with
compute_affected_sublibraries.jl . --root-matrix. Emitted(group, version)set:Core × {lts, 1, pre}reproduces the OLD matrix exactly (the whole suite previously ran on["1","lts","pre"], now grouped asCore).QA × {lts, 1}is newly wired.QA group newly wired; Aqua/JET run in CI — any failures will be triaged in follow-up.
Ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code