Canonical CI: grouped-tests.yml + root test/test_groups.toml#186
Merged
ChrisRackauckas merged 2 commits intoJun 10, 2026
Conversation
Convert the root test workflow (CI.yml, name "Tests") to the canonical
SciML/.github grouped-tests.yml@v1 thin caller, with the group x version
matrix declared in test/test_groups.toml at the repo root.
- CI.yml: replace the hand-maintained version: [1, lts] matrix job (which
called tests.yml@v1 directly with GROUP unset) with a thin
grouped-tests.yml@v1 caller. on: and concurrency: preserved verbatim.
No with: block needed (group-env-name=GROUP matches runtests.jl;
check-bounds/coverage/coverage-directories defaults are appropriate;
Linux-only so no os field).
- test/test_groups.toml: [Core] on [lts,1,pre]; [QA] on [lts,1].
- Refactor inline QA into a gated QA group with an isolated environment.
Previously Aqua (test/qa.jl) and ExplicitImports (test/explicit_imports.jl)
ran inline on every test run, and JET (test/jet/) had its own env gated on
GROUP==JET (which the old CI never set, so JET never ran). Now:
* runtests.jl reads GROUP (default "All"); Core/All runs the functional
suite, QA activates test/qa, develops the package, instantiates, and
runs test/qa/qa.jl.
* test/qa/Project.toml: isolated env (Aqua + ExplicitImports + JET + Test +
Distributions + LinearAlgebra; package via [sources] path="../.."; julia
compat "1.10").
* test/qa/qa.jl consolidates the Aqua, ExplicitImports, and JET checks.
* Aqua and ExplicitImports removed from the main test/Project.toml (now
QA-only).
Root Project.toml already has julia compat "1.10" and no [extras] (workspace
model), so no pre-emptive metadata fixes were required.
No tests, Aqua, or JET were run locally (structural conversion). The QA group
is newly wired; its Aqua/JET will run in CI.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…st_broken DifferenceEquations failed to even precompile under the dependabot-widened DiffEqBase 7.5 compat (DEProblem was removed in DiffEqBase 7), blocking all test groups. Restore the working DiffEqBase compat to 6.210.1 in both the root and test/ Project.toml (matches main; tightening, not weakening — the package source imports DiffEqBase.DEProblem, which only exists in 6.x). With the package loadable, the QA group's Aqua (10/10) and ExplicitImports (2/2) checks pass. Two JET static-analysis report_call checks surface genuine findings (no matching method get_concrete_noise / get_observable); mark them @test_broken so QA is green and the findings stay visible, tracked in SciML#187. QA group is ubuntu-only already (no os override in test/test_groups.toml). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the root test workflow to the canonical SciML/.github
grouped-tests.yml@v1thin caller, with the group × version matrix declared once intest/test_groups.tomlat the repo root.What changed
.github/workflows/CI.yml(name"Tests"): the hand-maintainedversion: [1, lts]matrix job (which calledtests.yml@v1directly withGROUPunset) becomes a thin caller ofgrouped-tests.yml@v1.on:andconcurrency:are preserved verbatim. Nowith:block is needed:group-env-namedefaultGROUPmatchesruntests.jl;check-bounds/coverage/coverage-directoriesdefaults are appropriate; the repo is Linux-only so there is noosfield.test/test_groups.toml(new, repo root):[Core]on[lts, 1, pre];[QA]on[lts, 1].test/qa.jl) and ExplicitImports (test/explicit_imports.jl) ran inline on every test run, and JET (test/jet/) had its own env gated onGROUP==JET— which the old CI never set, so JET never actually ran. Now:test/runtests.jlreadsGROUP(default"All").Core/Allruns the functional suite;QAactivatestest/qa,Pkg.develops the package, instantiates, and runstest/qa/qa.jl.test/qa/Project.toml: isolated env (Aqua + ExplicitImports + JET + Test + Distributions + LinearAlgebra; package via[sources]path="../..";juliacompat"1.10").test/qa/qa.jlconsolidates the Aqua, ExplicitImports, and JET checks (content unchanged from the originals).test/Project.toml(now QA-only).The root
Project.tomlalready hasjuliacompat"1.10"and no[extras](workspace model), so no pre-emptive metadata fixes were required.Matrix match
Old matrix:
testsjob onversion ∈ {1, lts},GROUPunset (so the whole suite, including Aqua/ExplicitImports, ran on each; JET never ran).New matrix, computed statically via
compute_affected_sublibraries.jl --root-matrix:Core reproduces the old functional-test version set
{lts, 1}and addspre(canonical default). QA{lts, 1}is the canonical default. All cells areubuntu-latest(Linux-only).test_groups.toml, bothProject.tomls, andCI.ymlall parse cleanly.Notes
Ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code