Use SciMLTesting v1.2 (folder-based run_tests)#189
Merged
ChrisRackauckas merged 1 commit intoJun 14, 2026
Conversation
Convert the test harness to SciMLTesting v1.2. The Core group's five Enzyme/gradient files are gated behind `CI != "true"` (skipped on CI); that guard cannot be expressed by folder-discovery (which runs every file in a group unconditionally), so Core is wired as an explicit `run_tests` `core` thunk that keeps the CI guard verbatim and runs each self-contained file under its own @safetestset. "All" is curated to ["Core"] so GROUP=All runs only Core (QA runs only for GROUP=QA), matching the previous runtests.jl. The QA env activation (activate/develop/instantiate + bare include of qa.jl) is kept as an explicit thunk so it stays byte-for-byte identical. Adds SciMLTesting + SafeTestsets to the test and qa test envs. test/data, test/utilities, and test/test_groups.toml are unchanged. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisRackauckas-Claude
force-pushed
the
canonicalize-safetestset
branch
from
0f4f4a1 to
4ea2f4e
Compare
ChrisRackauckas-Claude
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the test harness to the SciMLTesting v1.2 folder model.
DifferenceEquations is a single package with a
Coregroup and aQAgroup. TheCoregroup's five Enzyme/gradient test files are gated behindCI != "true"(they are skipped on CI). That CI guard cannot be expressed by SciMLTesting's folder-discovery mode (which discovers and runs every*.jlin a group folder unconditionally), so this PR uses the explicit-args form ofrun_tests— the same v1.2 backward-compatible path used by OrdinaryDiffEq.jl — with:corethunk that keeps theif get(ENV, "CI", "false") != "true"guard verbatim and runs each (already self-contained) test file under its own@safetestset;all = ["Core"]soGROUP=Allruns only the Core body (QA runs only forGROUP=QA), matching the previousruntests.jl;qathunk that activatestest/qa, develops the root package, instantiates, andincludesqa.jl— kept byte-for-byte identical to the previous QA path.SciMLTesting+SafeTestsetsare added to thetestandtest/qaenvironments.test/data,test/utilities, andtest/test_groups.tomlare unchanged.Verified statically: every
Project.toml/test_groups.tomlparses,runtests.jl+qa.jlparse, and a dispatch harness confirms the exact set of test files fired under eachGROUP×CIcombination is identical to the previous harness (All/Core = 13 files on CI, 18 locally; QA = qa.jl).Ignore until reviewed by @ChrisRackauckas.