Skip to content

Use SciMLTesting v1.2 (folder-based run_tests)#52

Merged
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:sciml-testing-rollout
Jun 14, 2026
Merged

Use SciMLTesting v1.2 (folder-based run_tests)#52
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:sciml-testing-rollout

Conversation

@ChrisRackauckas-Claude

@ChrisRackauckas-Claude ChrisRackauckas-Claude commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Converts the test suite to the SciMLTesting v1.2 folder-based run_tests() model.

test/runtests.jl is now just:

using SciMLTesting
run_tests()

Group routing is derived from the folder layout + test/test_groups.toml (unchanged):

  • Core = top-level test/*.jl (explicit_imports.jl + recipes.jl, the latter extracted from the old inline plotting smoke test in runtests.jl).
  • QA = test/qa/ with its existing per-group Project.toml sub-env (Aqua + JET).
  • All = Core (the only non-QA group), matching the previous GROUP == "All" || GROUP == "Core" behavior.

Deps: added SciMLTesting + SafeTestsets to the root [extras]/[targets].test/[compat] and to test/qa/Project.toml. test/test_groups.toml is unchanged. Per-GROUP file sets verified identical to master via folder discovery.

This supersedes the earlier v1.1.0 explicit-args rollout on this branch.

Ignore until reviewed by @ChrisRackauckas.

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Contributor Author

Updated to SciMLTesting v1.1.0 with the curated all = ["Core"] kwarg.

The first pass left all unset, so run_tests used the legacy fallback (core + every env-less group + qa), which ran QA under the bare/All group. But the master test/runtests.jl All/default branch ran only the Core body — QA was a separate if GROUP == "QA" branch never reached by All. The corrected call:

run_tests(;
    core = joinpath(@__DIR__, "core.jl"),
    qa = (; body = joinpath(@__DIR__, "qa", "qa.jl"), env = joinpath(@__DIR__, "qa")),
    all = ["Core"],
)

makes All/unset run exactly Core (QA omitted), Core run Core, and QA run the QA body — identical to master for every GROUP value. Behavior-equivalent refactor; no test-assertion or logic changes. Static-verified (TOML.parsefile + Meta.parseall on all test files).

Ignore until reviewed by @ChrisRackauckas.

@ChrisRackauckas-Claude ChrisRackauckas-Claude changed the title Use SciMLTesting v1.0.0 (run_tests harness) Use SciMLTesting v1.1.0 (run_tests harness, curated All) Jun 14, 2026
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ChrisRackauckas-Claude ChrisRackauckas-Claude changed the title Use SciMLTesting v1.1.0 (run_tests harness, curated All) Use SciMLTesting v1.2 (folder-based run_tests) Jun 14, 2026
@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review June 14, 2026 23:54
@ChrisRackauckas ChrisRackauckas merged commit d6ded01 into SciML:master Jun 14, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants