Canonical CI: grouped-tests.yml + root test/test_groups.toml#144
Merged
ChrisRackauckas merged 3 commits intoJun 10, 2026
Merged
Conversation
Convert the root test workflow (Tests.yml) to the canonical SciML thin caller using SciML/.github grouped-tests.yml@v1, with the version/OS matrix declared once in test/test_groups.toml. - Tests.yml becomes a thin caller (on:/concurrency:/name: preserved). - test/test_groups.toml reproduces the old matrix exactly: Core/"1" on ubuntu/windows/macOS-15-intel/macOS-latest, plus lts+pre on ubuntu-latest. arch is auto-detected from each runner (aarch64 on macOS-latest, x64 elsewhere), matching the old include arch axis. - runtests.jl gains GROUP dispatch; the existing suite runs under any non-QA group. - New QA group (test/qa/) wires Aqua.test_all + JET.test_package in an isolated environment. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The grouped-tests QA group activates test/qa as its own project, so the QA sub-env must carry Pkg (used by the activation/instantiate path). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…roken The grouped-tests QA group could not load under the reusable workflow because test/qa/qa.jl does `using Pkg` to activate test/qa/Project.toml, but the test target only listed Test + StableRNGs. Add Pkg to [extras]/[targets].test (with a Pkg = "1" compat entry so Aqua deps_compat stays green), matching the FastBroadcast.jl QA pattern. The QA group then surfaced genuine Aqua and JET findings. Keep all passing Aqua sub-checks running and mark only the failing checks broken: - Aqua ambiguities: 18 (optimize overloads, src/api/optimize.jl) - Aqua unbound_args: 3 methods (src/api/expressions.jl) - Aqua piracies: 7 methods (Expr ops, replace, value) - JET report_package: errors (+(::Nothing,::Int), kwcall on deprecated crossover/mutation aliases in src/deprecated.jl) Tracked in SciML#145 Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the root test workflow to the canonical SciML thin caller using
SciML/.githubgrouped-tests.yml@v1, with the test matrix declared once intest/test_groups.toml.Changes
.github/workflows/Tests.yml— now a thin caller ofgrouped-tests.yml@v1(secrets: inherit, nowith:needed: defaults match —GROUPenv name,check-bounds: yes, coverage on,src,extdirs).name:,on:, andconcurrency:preserved verbatim. No other workflows touched.test/test_groups.toml(new) — root matrix. The functional suite is split into two groups solely to reproduce the old non-uniform matrix exactly:[Core]version"1"onubuntu-latest, windows-latest, macOS-15-intel, macOS-latest[CoreLTSPre]versionslts, preonubuntu-latest[QA]versionslts, 1test/runtests.jl— addsGROUPdispatch. Every non-QAgroup runs the full existing functional suite;QAruns the QA file.test/qa/(new) — isolated QA environment (Aqua,JET,Test,Evolutionaryvia[sources]path) andqa.jlrunningAqua.test_all(Evolutionary)+JET.test_package(Evolutionary; target_defined_modules=true).Matrix match (verified statically via
compute_affected_sublibraries.jl --root-matrix)Old
Tests.ymlmatrix:1× {ubuntu-latest, windows-latest, macOS-15-intel, macOS-latest}lts× {ubuntu-latest}pre× {ubuntu-latest}Emitted functional cells are byte-for-byte the same 6-cell set. arch is auto-detected from each runner (
aarch64onmacOS-latest,x64elsewhere), matching the oldincludearch axis. The QA group (QA/lts,QA/1onubuntu-latest) is newly added.Notes
[compat] juliaalready"1.10"(LTS floor); all[extras]deps already have[compat]entries — no changes needed.Ignore until reviewed by @ChrisRackauckas.