Use SciMLTesting v1.2 (folder-based run_tests)#147
Merged
ChrisRackauckas merged 1 commit intoJun 14, 2026
Merged
Conversation
Convert test/runtests.jl to the SciMLTesting v1.2 harness. The functional suite is identical across the Core and CoreLTSPre groups (they only split the version/OS matrix), so they share one body thunk and `all = ["Core"]` keeps the local default running the suite exactly once. QA runs in its isolated test/qa env via the run_tests qa group spec. The per-file tests are now self-contained @safetestset bodies (each brings its own `using`s), and Pkg is dropped from the test deps (the harness owns env activation). test_groups.toml is unchanged. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisRackauckas-Claude
force-pushed
the
canonicalize-safetestset
branch
from
997c266 to
37addc3
Compare
ChrisRackauckas-Claude
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
test/runtests.jlto the SciMLTesting v1.2 harness.Shape
Multi-group single package.
test/test_groups.tomldeclaresCore,CoreLTSPre, andQA. TheCoreandCoreLTSPregroups run the identical functional suite — they exist only to split the version/OS CI matrix. This shared-file-set-across-two-groups shape cannot be expressed by SciMLTesting's bare folder-discovery mode (which would require duplicating the 16 files into atest/CoreLTSPre/folder and would double-run the suite under the localAlldefault), so this uses the v1.2 explicit-args form (still v1.2, the backward-compatiblerun_tests(; core, groups, qa, all)path) over a clean folder layout.Layout
test/*.jl(the 16 functional files), each now a self-contained@safetestsetbody that brings its ownusings.test/qa/with its owntest/qa/Project.tomlsub-env (Aqua + JET), activated by the harness.all = ["Core"]keepsGROUPunset (local default"All") running the functional suite exactly once.Behavior preservation
The exact set of tests run under each
GROUPvalue is unchanged from master:GROUP=Core,GROUP=CoreLTSPre, and the localAlldefault → the 16-file functional suite + the piracy guard, once.GROUP=QA→qa.jl(Aqua + the 4 tracked@test_brokenmarkers).Verified locally on Julia 1.11:
GROUP=Core→Testing Evolutionary tests passed;GROUP=QA→QA | 8 Pass, 4 Broken→Testing Evolutionary tests passed.test/test_groups.tomlis unchanged.Deps
Project.toml: addedSciMLTesting+SafeTestsets(+ compat) to[extras]/[targets].test/[compat]; droppedPkg(the harness owns env activation; notest/*.jlusesPkganymore).test/qa/Project.toml: addedSciMLTesting+SafeTestsets; droppedPkg.Ignore until reviewed by @ChrisRackauckas.