fix: restore Julia 1.10 support for Double64 intlog2 path + re-enable downgrade CI#223
Merged
ChrisRackauckas merged 3 commits intoJun 6, 2026
Conversation
… downgrade CI
The Issue-206 test "Double64 with pade order 13" errored on Julia 1.10 because
intlog2(::Double64) routed through ceil(UInt64, ::Double64), which requires
trunc(::Type{UInt64}, ::Double64). Julia 1.11's Base added a generic
trunc(::Type{<:Integer}, ::AbstractFloat) fallback, but 1.10 lacks it and
DoubleFloats never defines trunc for Unsigned. Routing intlog2 through a signed
Int (ceil(Int, ...)), which DoubleFloats does define, restores 1.10 support
with identical behavior (the argument is a positive, bounded operator norm;
verified byte-for-byte equal to the old result across the full input range).
Re-enable the downgrade workflow (remove `if: false`) and raise the lowest
[compat] floors that resolve and pass the Core suite on Julia 1.10:
- DoubleFloats: 1 -> 1.1.14 (1.0.x pins GenericSchur to <=0.4, conflicting with
GenericSchur 0.5.3; 1.1.14 is the first DoubleFloats allowing GenericSchur 0.5)
- StaticArrays: 1.2 -> 1.9.8 (versions < 1.9.8 either fail to precompile on
Julia 1.10 with `require_one_based_indexing not defined`, or hit an ambiguous
lu(::StaticMatrix, ::Val{true}) with LinearAlgebra's deprecated method)
Both suites run locally on Julia 1.10:
- latest compat: Quality Assurance 10/10, Basic Tests 329 pass / 1 broken
- downgrade floors: Quality Assurance 10/10, Basic Tests 329 pass / 1 broken
(the 1 broken is a pre-existing @test_broken; the Issue-206 Double64 test passes)
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Strict no-reresolve can't reconcile floored core deps against the latest-floating transitive SciML stack; reresolve still enforces the floor [compat] pins but resolves a consistent set. Verified locally. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Use the strict SciML default `allow-reresolve: false` so Pkg.test must instantiate the exact deps-floor + latest-transitive set with no reconciliation. Verified locally on Julia 1.10 (deps-mode: only [deps] [compat] pinned to floors, allow_reresolve=false): Quality Assurance: 10/10 Basic Tests: 329 pass, 1 broken (pre-existing @test_broken), 330 total "Testing ExponentialUtilities tests passed" (exit 0) No floor raises needed — current [deps] floors are strict-consistent with the latest transitive ecosystem. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
Update: downgrade made strict (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SciML policy requires every library to support Julia 1.10 (LTS), but the Core suite errored on 1.10 at latest compat and on master. The downgrade workflow was disabled (
if: false, tracking #208).The Issue-206 test
"Double64 with pade order 13"errored on Julia 1.10:Julia 1.11's Base added a generic
trunc(::Type{<:Integer}, ::AbstractFloat)fallback; 1.10 lacks it, and DoubleFloats never definestruncforUnsignedin any version. Soexponential!errored on 1.10. Reproduced:326 passed, 1 erroredon Julia 1.10.Fix (
src/exp_generic.jl)Route
intlog2's integer-conversion path through a signedIntinstead ofUInt:ceil(Int, x)only needstrunc(::Type{Int}, ::AbstractFloat), which DoubleFloats does define (it defines signedtruncforInt16/Int64/Int128/...but neverUnsigned). The argumentxis a positive operator norm bounded above by2^62(guarded just upstream), so the signed conversion is in-range and behavior is unchanged on 1.11+. Verified byte-for-byte equal to the oldceil(UInt, x)result across 10k random + boundary inputs (0 mismatches), including the2^62overflow guard.Re-enable downgrade CI + corrected floors (
Project.toml)Removed
if: falsefrom.github/workflows/Downgrade.yml. Raised the lowest[compat]floors that resolve and pass the Core suite on Julia 1.10:11.1.14<=0.4, conflicting with this package's GenericSchur0.5.3;1.1.14is the first DoubleFloats allowing GenericSchur 0.51.21.9.8< 1.9.8either fail to precompile on Julia 1.10 (require_one_based_indexing not defined) or hit an ambiguouslu(::StaticMatrix, ::Val{true})against LinearAlgebra's deprecated method(GenericSchur
0.5.3and all other floors were left unchanged — they resolve fine.)julia = "1.10"and the workflow'sjulia-version: "1.10"are unchanged, per the LTS policy.Local test results (Julia 1.10.11)
Latest compat:
Downgrade floors (DoubleFloats 1.1.14, GenericSchur 0.5.3, StaticArrays 1.9.8):
The 1 broken is a pre-existing
@test_broken(kiops, test/basictests.jl:293), untouched here. The previously-erroring Issue-206 Double64 test now passes.🤖 Generated with Claude Code