Use SciMLTesting v1.0.0 (run_tests harness)#228
Open
ChrisRackauckas-Claude wants to merge 1 commit into
Open
Conversation
Replace the hand-written GROUP-dispatch in test/runtests.jl with a single declarative SciMLTesting.run_tests call. Behavior-equivalent refactor: same group routing (Core/All and the per-repo named/QA groups), same test bodies. Add SciMLTesting to the test deps; drop Pkg from the test deps where it was only used by the old activate/develop/instantiate harness. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the hand-written
GROUP-dispatch intest/runtests.jlwith a single declarativeSciMLTesting.run_testscall (SciMLTesting v1.0.0).This is a pure, behavior-equivalent harness refactor — same group routing and same test bodies, just driven by
run_testsinstead of a copy-pastedif GROUP == ...ladder.Routing:
core=qa.jl+basictests.jl(main env, run under"All"/"Core");groups["GPU"]andgroups["JET"]each declare theirtest/gpu/test/jetsub-env via(; env = ..., body = ...), so (matching the original) they run only on an explicitGROUP=GPU/GROUP=JETand never under"All".activate_group_envreproduces the oldactivate_gpu_env/activate_jet_envhelpers. The unusedLONGER_TESTSglobal (referenced nowhere) is dropped.Pkgwas only used by the old harness, so it is dropped from[extras]/[targets]/[compat].Project.toml: add
SciMLTestingto[extras],[targets].test, and[compat](= "1").Verified statically (TOML parse +
Meta.parseallofruntests.jl) and the dispatch was checked against the realrun_testswith marker thunks to confirm eachGROUPselects the same bodies as before. Heavy suites left to CI.Ignore until reviewed by @ChrisRackauckas.