Improve explicit imports hygiene#55
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
Conversation
- Add explicit imports for all symbols used from dependencies - Remove reliance on transitive dependencies - Add ExplicitImports.jl tests to prevent regressions - Fix test imports to be explicit about ReturnCode and SecondOrderODEProblem All symbols from GeometricIntegrators, SciMLBase, DiffEqBase, and Reexport are now explicitly imported. ExplicitImports.jl tests confirm no implicit or stale imports remain. Tests: All existing tests pass + new ExplicitImports tests added Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves explicit imports hygiene for the package by:
ReturnCodeandSecondOrderODEProblemChanges
Source Code (
src/GeometricIntegratorsDiffEq.jl)GeometricIntegrators,SciMLBase,DiffEqBase, andReexportare now explicitly importedTests
ReturnCodeandSecondOrderODEProblemintest/runtests.jltest/explicit_imports_test.jlwith ExplicitImports.jl checksProject.tomlVerification
Confirmed with ExplicitImports.jl that:
This ensures the package follows best practices for dependency management and prevents issues with transitive dependencies.
cc @ChrisRackauckas
🤖 Generated with Claude Code