Fix ODE7 SciMLBase import in test and re-enable Downgrade CI#200
Merged
ChrisRackauckas merged 2 commits intoJun 7, 2026
Merged
Conversation
OrdinaryDiffEq 7.0.0 dropped the re-export of the `SciMLBase` name that test/diffeq.jl relied on (`sol.retcode == SciMLBase.ReturnCode.Success`), causing `UndefVarError: SciMLBase not defined` on master at latest deps. Add SciMLBase as a test dep ([extras] + test target + [compat]) and import it explicitly in test/diffeq.jl, rather than capping OrdinaryDiffEq to 6. Re-enable the Downgrade workflow (was `if: false`) with allow-reresolve: true and julia-version 1.10, and raise the [compat] floors to the lowest set that resolves and passes the downgrade suite: ArrayInterface: 7 -> 7.25 ChainRulesCore: 1 -> 1.26 ForwardDiff: 0.10.3, 1 -> 1.1 MacroTools: 0.5 -> 0.5.16 PreallocationTools: 0.4, 1.0 -> 1.2 PrecompileTools: 1 -> 1.2.1 RecursiveArrayTools: 3.1, 4 -> 3.54, 4 StaticArrays: 1.0 -> 1.9.18 Downgrade suite run locally on Julia 1.10 at these floors (deps-mode pins, allow_reresolve=true, OrdinaryDiffEq/SciMLBase floating to latest 7.x/3.x): PASS. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Switch the Downgrade.yml caller from allow-reresolve: true to the strict SciML default allow-reresolve: false. With reresolve disabled, julia-downgrade-compat pins [deps] to their declared floors, floats transitive deps to latest, and Pkg.test must instantiate that exact set with no reconciliation. Verified locally on Julia 1.10 (deps-mode: [deps] [compat] pinned to floors, extras/transitive floated to latest, Pkg.test(allow_reresolve=false)): all test groups pass at the current floors with no floor raises needed. SciMLBase 3.18 / OrdinaryDiffEq 7.0 / RecursiveArrayTools 4.x (latest transitive) coexist with the pinned [deps] floors. Strict downgrade suite: PASS. Test summary: SLArrays / LArrays (72 pass, 4 pre-existing @test_broken) / DiffEq (9 pass) ChainRules (50 pass) / RecursiveArrayTools (1 pass) -> Testing LabelledArrays tests passed Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two coupled fixes — the test fix is the prerequisite for the downgrade CI to be testable.
1. Fix pre-existing master test failure (ODE7)
test/diffeq.jl:18does@test sol.retcode == SciMLBase.ReturnCode.Successbut the file onlyusing LabelledArrays, OrdinaryDiffEq, Test. It relied on OrdinaryDiffEq 6.x re-exporting theSciMLBasename. OrdinaryDiffEq 7.0.0 (now latest) dropped that re-export, so master fails withUndefVarError: SciMLBase not definedat latest deps on Julia 1.10.Fixed the right way (NOT by capping OrdinaryDiffEq to 6, which would hide the real ODE7 incompatibility):
SciMLBaseto[extras], thetesttarget, and[compat]("2, 3").using SciMLBasetotest/diffeq.jl.2. Re-enable Downgrade CI
The workflow was
if: false(old comment about StaticArrays floor conflict). Re-enabled withallow-reresolve: trueandjulia-version: "1.10"(LTS retained). Raised[compat]floors to the lowest set that resolves and passes the downgrade suite:77.2511.260.10.3, 11.10.50.5.160.4, 1.01.211.2.13.1, 43.54, 41.01.9.18Local verification (Julia 1.10.11)
Pkg.test()PASS with OrdinaryDiffEq 7.0.0 resolved. DiffEq testset 9/9 (wasUndefVarErrorbefore).Pkg.test(allow_reresolve=true), OrdinaryDiffEq/SciMLBase floating to latest 7.x/3.x): PASS.🤖 Generated with Claude Code