Add hasneuralnetwork and hasneuralnetworkps accessor functions#113
Open
TorkelE wants to merge 3 commits into
Open
Add hasneuralnetwork and hasneuralnetworkps accessor functions#113TorkelE wants to merge 3 commits into
hasneuralnetwork and hasneuralnetworkps accessor functions#113TorkelE wants to merge 3 commits into
Conversation
Member
|
can you rebase this on to of the other PR and make the PR against that branch? That way, when that gets merged you don't have to do anything and the merge target will just change to main |
Member
Author
|
My intention was to do something like that but it didnät work out (probably due to my lacklustre git knowledge...). Once #112 is merged, I will rebase this one on master and it should be good. |
Member
|
merged, release on the way JuliaRegistries/General#151423 |
Member
Author
|
Ok, this should be properly on the main branch now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions were initially part of: #112, however, their tests caused some failure on lts due to an unknown Symbolics issue. For now I have moved these two to a separate PR, which can be merged when said Symbolics issue has been figured out. In the meantime, it should mean that it should be possible to merge #112.