Bump compat for OrdinaryDiffEq v7 / SciMLBase v3 ecosystem#120
Merged
ChrisRackauckas merged 2 commits intoMay 9, 2026
Merged
Conversation
- OrdinaryDiffEqVerner: "1.2" → "1, 2" to allow v2 (part of OrdinaryDiffEq v7 ecosystem) - docs: OrdinaryDiffEqTsit5: "1" → "1, 2" - docs: OrdinaryDiffEqVerner: "1" → "1, 2" - docs: SciMLBase: "2" → "2, 3" No source code changes required: no deprecated SciMLBase v2 APIs (u_modified!, DEAlgorithm, sol.destats, etc.) are used in src/ or tests. SciMLBase.FullSpecialize and SciMLBase.successful_retcode remain valid in v3. Refs: SciML/OrdinaryDiffEq.jl#3562, SciML/OrdinaryDiffEq.jl#3565 Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
The format-check workflow invoked fredrikekre/runic-action@v1 without first installing Julia, so the action's dependency-check step bailed out with "julia is a required dependency but does not seem to be available" before any code was inspected. This masked pre-existing Runic violations in src/ and test/. - .github/workflows/FormatCheck.yml: add julia-actions/setup-julia@v2 before the runic-action step so Julia is on PATH. - src/ModelingToolkitNeuralNets.jl, src/nn_par_accessors.jl, test/nn_ps_accessors.jl, test/symbolicnn_macro.jl: apply `runic --inplace` to the formatting violations the action will now flag (whitespace around operators, explicit `return` on single-statement function bodies, line-wrapping of long expressions, trimming a duplicated blank line). All changes are formatting-only; no semantic changes. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Author
|
Pushed c21c731 to fix
The other two failures on the previous CI run are not caused by this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps compat entries to allow the OrdinaryDiffEq v7 / SciMLBase v3 ecosystem (refs SciML/OrdinaryDiffEq.jl#3562, SciML/OrdinaryDiffEq.jl#3565 and NEWS.md):
Project.toml:OrdinaryDiffEqVerner"1.2"→"1, 2"(v2 is the OrdinaryDiffEq v7-compatible release)docs/Project.toml:OrdinaryDiffEqTsit5"1"→"1, 2"docs/Project.toml:OrdinaryDiffEqVerner"1"→"1, 2"docs/Project.toml:SciMLBase"2"→"2, 3"No source/test code changes needed
Audited all src/ and test/ files for breaking patterns from the v7/v3 ecosystem:
u_modified!,DEAlgorithm,DEProblem,DESolution,sol.destats,has_destats)SciMLBase.FullSpecializeandSciMLBase.successful_retcoderemain valid in SciMLBase v3sol[i]indexing patterns that would break under RecursiveArrayTools v4Test plan