Skip to content

Fix #67: Add offset methods for boundaries and include dispatch tests#70

Open
utkuyilmaz1903 wants to merge 1 commit into
SciML:masterfrom
utkuyilmaz1903:fix-boundary-offset
Open

Fix #67: Add offset methods for boundaries and include dispatch tests#70
utkuyilmaz1903 wants to merge 1 commit into
SciML:masterfrom
utkuyilmaz1903:fix-boundary-offset

Conversation

@utkuyilmaz1903
Copy link
Copy Markdown

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Resolves #67.

Implemented "Option A" as suggested by @xtalax to provide fallback offset implementations for boundary types.

Key details:

  • Added offset methods directly to LowerBoundary and UpperBoundary (instead of AbstractLowerBoundary / AbstractUpperBoundary as originally suggested, since those abstract types are not defined in the current hierarchy and caused an UndefVarError during local testing).
  • Added a new @safetestset to verify correct dispatch and offset calculations, preventing future regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HigherOrderInterfaceBoundary missing from offset/boundary dispatch interface

1 participant