Use SciMLTesting v1.2 (folder-based run_tests)#101
Merged
ChrisRackauckas merged 1 commit intoJun 14, 2026
Conversation
ParallelParticleSwarms's Core group runs gpu/constraints/lbfgs inside a
backend loop (`@testset for BACKEND in unique(("CPU", CI_GROUP))`) that
mutates a shared `GROUP` global read by the `utils.jl` helper, with those
files run as plain (non-safetestset) `@testset`s sharing one scope. That
coupling cannot be expressed by v1.2 folder-discovery (which runs each
file once as an isolated @safetestset), so the Core group uses the
explicit-args `core` thunk, preserving the original control flow verbatim.
QA is moved into the test/qa/ folder and canonicalized to @safetestset:
test/qa.jl is split into test/qa/qa.jl (a thin @safetestset wrapper) and
test/qa/jet_tests.jl (the JET checks). runtests.jl becomes a single
run_tests(; env="PPS_TEST_GROUP", core=..., qa=...) call.
Deps: add SciMLTesting (compat "1") to test/Project.toml and
test/qa/Project.toml; add SafeTestsets (compat "0.0.1, 0.1") to
test/qa/Project.toml; drop Pkg from test/Project.toml (the harness owns
all Pkg ops now). test/test_groups.toml is unchanged.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisRackauckas-Claude
force-pushed
the
sciml-testing-rollout
branch
from
d029c8b to
8a98cc8
Compare
ChrisRackauckas-Claude
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the test suite to the SciMLTesting v1.2
run_testsharness.ParallelParticleSwarms's
Coregroup runsgpu.jl/constraints.jl/lbfgs.jlinside a backend loop (@testset for BACKEND in unique(("CPU", CI_GROUP))) that mutates a sharedGROUPglobal read by theutils.jlhelper, with those files run as plain (non-@safetestset)@testsets sharing one scope. That coupling cannot be expressed by v1.2 folder-discovery (which runs each file once as an isolated@safetestsetand would treatutils.jlas a test file), so theCoregroup uses the explicit-argscorethunk, which preserves the original control flow verbatim. This is the same explicit-args path used by RecursiveArrayTools/OrdinaryDiffEq for shapes folder-discovery cannot express.runtests.jlbecomes a singlerun_tests(; env = "PPS_TEST_GROUP", default = "Core", core = ..., qa = ...)call.QAis moved intotest/qa/and canonicalized to@safetestset:test/qa.jlis split intotest/qa/qa.jl(a thin@safetestsetwrapper) andtest/qa/jet_tests.jl(the JET checks).SciMLTesting(compat"1") added totest/Project.tomlandtest/qa/Project.toml;SafeTestsets(compat"0.0.1, 0.1") added totest/qa/Project.toml;Pkgdropped fromtest/Project.toml(the harness owns allPkgops).test/test_groups.tomlis unchanged.Behavior-preserving: the exact set of tests run under
PPS_TEST_GROUP=CoreandPPS_TEST_GROUP=QAis unchanged.Ignore until reviewed by @ChrisRackauckas.