Use SciMLTesting v1.2 (folder-based run_tests)#454
Merged
ChrisRackauckas merged 1 commit intoJun 14, 2026
Conversation
Convert test/runtests.jl to the SciMLTesting v1.2 folder-discovery model: runtests.jl is now `using SciMLTesting; run_tests()`. Core = top-level test/*.jl; the former test/layers/ and test/models/ files (which GROUP=Core already ran) are flattened to the top level so the Core glob discovers them. QA = test/qa/ (unchanged). Adds SciMLTesting to the root test deps and to test/qa/Project.toml; drops Pkg (the v1.2 harness owns all Pkg operations). test/test_groups.toml unchanged. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Saswatsusmoy
added a commit
to Saswatsusmoy/ReservoirComputing.jl
that referenced
this pull request
Jun 15, 2026
Resolve PR2 vs master conflicts after the SciMLTesting v1.2 migration landed on master (PR SciML#454, SciML#453, SciML#452, SciML#451, SciML#449): - Project.toml: keep our weakdeps (DataInterpolations, OrdinaryDiffEq, SciMLBase), our compat bumps (NNlib 0.9.30, PrecompileTools 1.2), and our test extras. Adopt master's SciMLTesting test dep, drop the Pkg test dep that master removed (the v1.2 harness owns Pkg ops). - test/runtests.jl: replace the hand-rolled SafeTestsets + GROUP dispatch with `using SciMLTesting; run_tests()` — folder-discovery picks up `test/test_ode_reservoir_ext.jl` and `test/test_sciml_reservoir.jl` automatically. Also follow up on Francesco's PR-wide style review: - Rename the remaining single-letter `u` / `u_val` bindings inside RHS bodies in ext + tests + the docs example to `input_t` for consistency with the rename pass already applied PR-wide. - Add a Lorenz chaos-forecasting eye-test section in the SciML reservoir tutorial that mirrors the README ESN example but feeds the raw leaky-integrator continuous ESN equations into a `SciMLProblemReservoir` (no CTESN struct yet, per Francesco's ask). Local replay (Julia 1.10, SciMLTesting v1.2 folder-discovery): GROUP=Core passes all groups including `Core/test_ode_reservoir_ext.jl` 34/34 and `Core/test_sciml_reservoir.jl` 24/24.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the test suite to the SciMLTesting v1.2 folder-discovery model.
test/runtests.jlis now simplyusing SciMLTesting; run_tests().test/*.jlfiles. The formertest/layers/*.jlandtest/models/*.jlfiles — whichGROUP=Corealready ran — are flattened to the top level so the Core glob discovers them (folder-discovery does not recurse into subfolders). All 21 Core test files are each run in their own isolated@safetestset, exactly as before.test/qa/with its ownProject.tomlsub-env (unchanged location).SciMLTestingto the root[extras]/[targets].test/[compat]and totest/qa/Project.toml; droppedPkgfrom the root test deps (the v1.2 harness owns allPkgoperations — confirmed no othertest/*.jlusesPkg).test/test_groups.tomlis unchanged.Behavior-preserving: the set of test files run under each
GROUPvalue (Core/All/QA) is identical to the previous grouped dispatcher (verified by simulating v1.2 folder-discovery against the new layout — 21 Core files + QA'sqa.jl).Ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code