Skip to content

Re-order pre-commit template#273

Merged
ukmo-ccbunney merged 1 commit into
SciTools:mainfrom
trexfeathers:re-order-precommit
Jul 22, 2026
Merged

Re-order pre-commit template#273
ukmo-ccbunney merged 1 commit into
SciTools:mainfrom
trexfeathers:re-order-precommit

Conversation

@trexfeathers

Copy link
Copy Markdown
Contributor

Ref SciTools/iris#7204

Hooks that modify files should run before hooks that report errors - otherwise the reported line numbers could be inaccurate (e.g. ruff splitting something over multiple lines).

@ukmo-ccbunney ukmo-ccbunney self-assigned this Jul 22, 2026

@ukmo-ccbunney ukmo-ccbunney left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for jumping on that so quickly @trexfeathers.
LGTM!

@ukmo-ccbunney
ukmo-ccbunney merged commit 1664a9e into SciTools:main Jul 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants