-
Notifications
You must be signed in to change notification settings - Fork 0
Refactoring #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Refactoring #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of gettext(), gettextf() functions to obtain the French version of tables.
…m the same package into a single statement.
…alized in utils.R
Member
|
A couple of comments:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a set of modifications proposed in this pull request.
🧹 Dependency Updates
Updated dependencies: {svBase} and {equatiomatic}.
Removed obsolete dependencies: {data.io} and {svMisc}.
🧱 Refactored tabularise_***() Methods
All tabularise_***() methods for objects such as lm, summary.lm, pls, summary.nls, glm, summary.glm, anova, and aov have been refactored.
This includes functions like tabularise_glance.glm(), tabularise_default.glm(), and tabularise_tidy.glm().
The refactoring improves internal consistency and lays the groundwork for supporting multiple table rendering formats via {flextable}, {tinytable}, and {gt}.
🆕 New Functions :
Introduced summary_(), anova_() functions:
These mirror the behavior of summary() and anova() but retain a reference to the original model object via an added attribute. This allows retrieval of metadata that would otherwise be lost.
Added experimental lm_(), glm_() and nls_() functions:
These extend {stats::lm()}, {stats::glm()} and {stats::nls()} by attaching metadata such as variable labels and units. Argument order now begins with data =, and all three functions (lm_(), glm_(), nls_()) use a data-dot mechanism inspired by svMisc::eval_data_dot().
Note: nls_() defaults to model = TRUE, unlike the base nls() which defaults to FALSE.