Conversation
only pylint rule missing in ruff is too-many-ancestors
fixes PLR5501 errors
fixes E713
only pylint rule missing in ruff is too-many-ancestors
fixes PLR5501 errors
fixes E713
# Conflicts: # SPRINTLOG.md
…dds_cli into forked-branch
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 93dbcd907e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Install ruff | ||
| run: pip install ruff |
There was a problem hiding this comment.
Pin Ruff version in CI to keep lint checks reproducible
Installing Ruff with pip install ruff pulls the latest release on every run, so lint/format outcomes can change without any code changes (for example when a new Ruff release adds checks under the enabled E/F/PL rule families or changes formatting behavior). This makes CI non-deterministic and can suddenly block merges or make old commits fail on rerun; pinning Ruff to a known version avoids that regression.
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #929 +/- ##
=======================================
Coverage 54.45% 54.45%
=======================================
Files 33 33
Lines 3043 3043
=======================================
Hits 1657 1657
Misses 1386 1386 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Template
Before Marking as Ready for Review
dev(or other targeted branch)SPRINTLOG.mdif neededIf the target branch is
master:Summary
Workaround for #927
Related Issue/Ticket
Link GitHub issue or provide Jira ID.
Testing
If applicable: How did you verify the change? Include commands, data, or screenshots.
Reviewer Notes
Anything that helps reviewers (e.g. areas needing close attention).
Once all boxes are checked, mark the PR as Ready for Review and tag at least one team member as the initial reviewer.