Conversation
delete to rm and list to ls, follows e.g. files cli now
There was a problem hiding this comment.
Pull request overview
This pull request implements a new version update subcommand for the divbase-cli tool, allowing users to modify the name and/or description of existing project versions. The PR also refactors command names to use Unix-style short forms (ls and rm instead of list and delete), aligning with existing conventions in the file CLI.
Changes:
- Added
version updatesubcommand with support for updating version names and descriptions - Renamed version CLI commands from
list/deletetols/rmfor consistency - Improved error messages for better clarity and consistency across version operations
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e_integration/cli_commands/test_version_cli.py | Updated all tests to use new command names (ls, rm) and added comprehensive e2e tests for the update functionality including edge cases |
| packages/divbase-lib/src/divbase_lib/api_schemas/project_versions.py | Added UpdateVersionRequest and UpdateVersionResponse schema models for the update API endpoint |
| packages/divbase-cli/src/divbase_cli/services/project_versions.py | Implemented update_version_command service function to handle API communication for updates |
| packages/divbase-cli/src/divbase_cli/cli_commands/version_cli.py | Added update command, renamed list to ls and delete to rm, with proper validation and user feedback |
| packages/divbase-api/src/divbase_api/routes/project_versions.py | Added PATCH /update endpoint with proper authorization checks for EDIT role |
| packages/divbase-api/src/divbase_api/crud/project_versions.py | Implemented update_project_version function with database operations, error handling, and improved error messages |
| docs/user-guides/project-versioning.md | Added comprehensive documentation for the update subcommand with examples and usage notes |
| docs/cli/_auto_generated/version.md | Updated auto-generated CLI documentation to reflect new command names |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/divbase-cli/src/divbase_cli/cli_commands/version_cli.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@brinkdp , this one is ready for review, I feel happy with the changes so feel free to skim it or give a LGTM if you prefer |
brinkdp
left a comment
There was a problem hiding this comment.
Clear and clean implementation and useful functionality to have. Thanks for harmonising the subcommands (ls, rm). That's a small change that makes a big impact on UX.
LGTM!
Relatively simple change to add ability to modify the name and/or description of existing project versions in divbase.
PR covers:
As we discussed a while ago (and as written in the docs):
Will take a review from copilot first.