chore: sweep hygiene — dedupe rstest exclude, drop dead Overview, move Codex MCP token note into capability table - #431
Merged
Conversation
…e Codex MCP token note into capability table - examples/rsc-agent-runtime/rstest.config.ts: remove the duplicate exclude key (TS1117); keep tests/route-unit/**. - packages/workbench: delete the unused Overview export from overview-page.tsx (main.tsx renders its own); HostAdoptionSection and BundleWorkflow stay shared; the unit test renders HostAdoptionSection directly. - codex-0.147.0.json: add the dated mcp.pathTokenLowering row; the website generator reads its reason instead of a hardcoded per-host note map. Codex adapterRevision 1.11.0 -> 1.12.0.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
🦋 Changeset detectedLatest commit: 769a61f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Owner
Author
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three hygiene items from the final sweep (lane B1):
examples/rsc-agent-runtime/rstest.config.tshad twoexclude:keys in one object literal (TS1117 when type-checked; the second silently won at runtime). Keptexclude: ['tests/route-unit/**']— the broader form the comment describes — and orderedincludebeforeexcludelike the root rstest configs.packages/workbench/src/overview-page.tsxexported anOverviewcomponent that no production code rendered:main.tsxdefines and renders its ownOverview(with the extraruntimeDiagnosticprop) and imports onlyBundleWorkflowandHostAdoptionSectionfromoverview-page.tsx. The only consumer of the exported copy wastests/overview-page.test.ts. Deleted the dead copy and its now-unused imports/helpers (useState,Diagnostic,ProjectClient,overviewFor,Navigation,Topbar,dateTime,stateLabel,sourceFor).HostAdoptionSectionandBundleWorkflowremain exported and shared. The unit test now rendersHostAdoptionSectiondirectly withoverviewFor(status)— the same wiringmain.tsxuses — and asserts theAB7211gate diagnostic through the model.${PLUGIN_ROOT}note moved out of the website generator's hardcodedmcpPathTokenNotesmap (en + zh) intopackages/agent-bundle/src/adapters/capabilities/codex-0.147.0.jsonas a datedmcp.pathTokenLoweringrow (state: degraded,fields,reason= the previous note verbatim, 2026-09-03 evidence citingcodex.tsand thecodex.mcp.token.*diagnostics).website/plugins/generated-reference.tsnow readsmcp.pathTokenLowering.reasonwhen a host records nomcp.pathTokensfields; the per-locale map is deleted (the zh page already documents that table content stays in English). CodexadapterRevisionbumped1.11.0 → 1.12.0;tests/adapter-metadata.test.tspin updated. Changeset:.changeset/codex-mcp-path-token-lowering-row.md(patch).Evidence
tsc --ignoreConfig --noEmit … rstest.config.tson the origin/main copy →error TS1117: An object literal cannot have multiple properties with the same name(line 11); on this branch → exit 0.rstest list --config rstest.config.tscollects the identical file set before/after and never liststests/route-unit/**.pnpm examples:checkpasses (the rsc-agent-runtimecheckranvalidate,build,typecheck,test,test:routes).rg -n "Overview\b" packages/workbench/src→ definitions atmain.tsx:377(rendered atmain.tsx:1488) andoverview-page.tsx:114(exported, imported only bytests/overview-page.test.ts).tsc --project packages/workbench/tsconfig.json(viapnpm typecheck) andpnpm lintclean;overview-page.test.tspasses.pnpm docs:site:buildpasses (language parity OK); the rendered note is present inwebsite/doc_build/reference/hosts.htmlandwebsite/doc_build/zh/reference/hosts.html(1 match each, codex row of "MCP transports and token fields").adapter-metadata.test.tsandadapter-capability-states.test.tspass with the new revision.Test plan
pnpm typecheck— exit 0pnpm lint— 0 errors, 0 warnings (1161 files)pnpm test:unit— 3002 passed, 1 failed:native-claude-contract.test.ts :: fails closed when the candidate plugin, exact Skill event, or subscription auth source is absenttimes out at 5000 ms identically on pristineorigin/mainin this environment (a realclaudebinary is on PATH here); unrelated to this PR — CI is authoritative.pnpm test:projection— 145 passedpnpm examples:check— exit 0pnpm docs:site:build— exit 0Review status
769a61f50d991607d4e2afed8fb2d916ee1a5e2c.chatgpt-codex-connector: quota exhausted — replied "You have reached your Codex usage limits for code reviews" to both the automatic trigger (2026-09-03T16:51:07Z) and the explicit@codex reviewrequest (2026-09-03T16:51:53Z). No review threads exist.656361ffe20c1f41859a0ebc978d75dac5af5039(initial sweep commit) and769a61f50d991607d4e2afed8fb2d916ee1a5e2c(changeset PR-number fix, head). Merging on CI green per lane rules; a follow-up review can target the squash commit onmain.