Skip to content

chore: sweep hygiene — dedupe rstest exclude, drop dead Overview, move Codex MCP token note into capability table - #431

Merged
ScriptedAlchemy merged 2 commits into
mainfrom
chore/sweep-hygiene
Sep 3, 2026
Merged

ScriptedAlchemy merged 2 commits into
mainfrom
chore/sweep-hygiene

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Sep 3, 2026 •

Copy link
Copy Markdown
Owner

Summary

Three hygiene items from the final sweep (lane B1):

  1. examples/rsc-agent-runtime/rstest.config.ts had two exclude: keys in one object literal (TS1117 when type-checked; the second silently won at runtime). Kept exclude: ['tests/route-unit/**'] — the broader form the comment describes — and ordered include before exclude like the root rstest configs.
  2. packages/workbench/src/overview-page.tsx exported an Overview component that no production code rendered: main.tsx defines and renders its own Overview (with the extra runtimeDiagnostic prop) and imports only BundleWorkflow and HostAdoptionSection from overview-page.tsx. The only consumer of the exported copy was tests/overview-page.test.ts. Deleted the dead copy and its now-unused imports/helpers (useState, Diagnostic, ProjectClient, overviewFor, Navigation, Topbar, dateTime, stateLabel, sourceFor). HostAdoptionSection and BundleWorkflow remain exported and shared. The unit test now renders HostAdoptionSection directly with overviewFor(status) — the same wiring main.tsx uses — and asserts the AB7211 gate diagnostic through the model.
  3. Codex MCP ${PLUGIN_ROOT} note moved out of the website generator's hardcoded mcpPathTokenNotes map (en + zh) into packages/agent-bundle/src/adapters/capabilities/codex-0.147.0.json as a dated mcp.pathTokenLowering row (state: degraded, fields, reason = the previous note verbatim, 2026-09-03 evidence citing codex.ts and the codex.mcp.token.* diagnostics). website/plugins/generated-reference.ts now reads mcp.pathTokenLowering.reason when a host records no mcp.pathTokens fields; the per-locale map is deleted (the zh page already documents that table content stays in English). Codex adapterRevision bumped 1.11.0 → 1.12.0; tests/adapter-metadata.test.ts pin updated. Changeset: .changeset/codex-mcp-path-token-lowering-row.md (patch).

Evidence

  • Item 1: tsc --ignoreConfig --noEmit … rstest.config.ts on the origin/main copy → error TS1117: An object literal cannot have multiple properties with the same name (line 11); on this branch → exit 0. rstest list --config rstest.config.ts collects the identical file set before/after and never lists tests/route-unit/**. pnpm examples:check passes (the rsc-agent-runtime check ran validate, build, typecheck, test, test:routes).
  • Item 2: rg -n "Overview\b" packages/workbench/src → definitions at main.tsx:377 (rendered at main.tsx:1488) and overview-page.tsx:114 (exported, imported only by tests/overview-page.test.ts). tsc --project packages/workbench/tsconfig.json (via pnpm typecheck) and pnpm lint clean; overview-page.test.ts passes.
  • Item 3: pnpm docs:site:build passes (language parity OK); the rendered note is present in website/doc_build/reference/hosts.html and website/doc_build/zh/reference/hosts.html (1 match each, codex row of "MCP transports and token fields"). adapter-metadata.test.ts and adapter-capability-states.test.ts pass with the new revision.

Test plan

  • pnpm typecheck — exit 0
  • pnpm lint — 0 errors, 0 warnings (1161 files)
  • pnpm test:unit — 3002 passed, 1 failed: native-claude-contract.test.ts :: fails closed when the candidate plugin, exact Skill event, or subscription auth source is absent times out at 5000 ms identically on pristine origin/main in this environment (a real claude binary is on PATH here); unrelated to this PR — CI is authoritative.
  • pnpm test:projection — 145 passed
  • pnpm examples:check — exit 0
  • pnpm docs:site:build — exit 0

Review status

  • CI: all required checks green on 769a61f50d991607d4e2afed8fb2d916ee1a5e2c.
  • chatgpt-codex-connector: quota exhausted — replied "You have reached your Codex usage limits for code reviews" to both the automatic trigger (2026-09-03T16:51:07Z) and the explicit @codex review request (2026-09-03T16:51:53Z). No review threads exist.
  • Last codex-reviewed SHA: none.
  • Unreviewed SHAs: 656361ffe20c1f41859a0ebc978d75dac5af5039 (initial sweep commit) and 769a61f50d991607d4e2afed8fb2d916ee1a5e2c (changeset PR-number fix, head). Merging on CI green per lane rules; a follow-up review can target the squash commit on main.

…e Codex MCP token note into capability table

- examples/rsc-agent-runtime/rstest.config.ts: remove the duplicate exclude key (TS1117); keep tests/route-unit/**.
- packages/workbench: delete the unused Overview export from overview-page.tsx (main.tsx renders its own); HostAdoptionSection and BundleWorkflow stay shared; the unit test renders HostAdoptionSection directly.
- codex-0.147.0.json: add the dated mcp.pathTokenLowering row; the website generator reads its reason instead of a hardcoded per-host note map. Codex adapterRevision 1.11.0 -> 1.12.0.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@changeset-bot

changeset-bot Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 769a61f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
agent-bundle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ScriptedAlchemy

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@pkg-pr-new

pkg-pr-new Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle@431
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/create-agent-bundle@431
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/@agent-bundle/runtime@431

commit: 769a61f

@ScriptedAlchemy
ScriptedAlchemy merged commit f4572a3 into main Sep 3, 2026
13 checks passed
@ScriptedAlchemy
ScriptedAlchemy deleted the chore/sweep-hygiene branch September 3, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant