refactor(install): delete legacy receipt and state readers - #841
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: ad2df47 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delete the installer's readers of old on-disk formats. #810 kept these to upgrade or remove older installs in place. The owner chose to drop them. An install the current format cannot prove is ours is now foreign, so the installer refuses it instead of adopting or purging it.
Removal matrix
agent-bundle-install-receipt/1)install,uninstall,doctor, emittedinstall.mjslegacyInstallReceiptFormat, receipt synthesis,migratedFrom,AB7329installSurfaceMarkerFiles, ownership'legacy', identical-copy adoption,forced-legacy,isRuntimeStateRemnant<plugin root>/state(pre-#640)doctor,uninstall,format.tsstateSource 'legacy',legacyDurableState,--purge-dataof it,AB7332stateRootfielddoctor,uninstall,state-root.tsisRecordedDerivedStateRootpurge authority'unsupported'runtime statusevents/ipc.ts,doctorAB7317; a rejected status probe is a failed probe (AB7318)Kept:
uninstall --forcefor current-format cases (edited owned files, host-registered plugin without a store receipt), receipts without astateblock (crash window of the current writer), and every path, symlink, and foreign-data guard.Consumer impact
A Cursor directory without a format-2 receipt naming the plugin is refused.
installreportsAB7005with or without--replace.uninstallreportsAB7007with or without--force. Doctor reportsAB7321. Remove the directory by hand and reinstall. An in-treestate/directory is retained and listed, never purged.Verification
On
88a1b646a7, rebased ontoorigin/mainafter #810 merged (18a913e9d8):pnpm build: passpnpm typecheck: passpnpm lint: passpnpm test:unit: pass (309 files, 4,480 tests)pnpm test:integration:run: pass (whole pool, 104 files, 1,187 tests)pnpm test:packedon packed-install-bin, packed-readonly-state-root, packed-host-install-proof, public-api-packed: pass (4 files, 14 tests)pnpm docs:site:build: pass (language parity OK, diagnostics coverage OK, 0 broken links)Review
Independent review (GPT-5.6, change-risk pass) found three items.
uninstall --forceon a host-registered plugin with no store receipt (forced-missing), plus--purge-data, removes web-data without receipt authority. The same purge candidate already exists on the base branch (installedWebDataRootinpublicHostData). This PR only removes the legacystate/candidate from that list, so it narrows the behavior. Whetherforced-missingshould purge at all is a separate product decision.install.mjsdrops a receiptstateblock whose owner mismatches instead of rejecting the receipt. That logic is unchanged from the base branch (surface.ts:1208). Follow-up, not legacy removal.#818changeset saiduninstall --forceremoves pre-receipt copies. That sentence is dropped because this PR removes the behavior in the same release.