fix(exec): name the daemon failure seen while reattaching - #323
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: ac381be The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ScriptedAlchemy
force-pushed
the
fix/exec-reconnect-error
branch
from
September 26, 2026 00:56
21456ba to
ff90e2a
Compare
ScriptedAlchemy
force-pushed
the
fix/exec-reconnect-error
branch
from
September 26, 2026 00:58
ff90e2a to
ac381be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A foreground exec that lost its daemon during a restart printed
daemon startup failed: ConnectionClosed:with an empty message. The client was reattaching, not starting a daemon. Each typed reattach failure now prints its own message.Scope
.changeset/exec-reconnect-error.mdsrc/internal/client/exec.tstests/integration/client-exec.test.tsBlast Radius
Only the named message or document changes. Other paths are unchanged.
Verification
The failing test landed first and passes on the fix. Changed tests and
pnpm typecheckpass locally.Principles