Update Unit.cs #17
Open
Update Unit.cs #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BugFix for when the path changes but the coroutine runs until the next yield statement, causing an error to throw when the pathIndex on line 62 is bigger than what the new path's turnBoundaries length. Checking with a hash means that at least *most* of the time this error doesn't come to pass, and is not resource intensive whatsoever on the method. The possibilities of having two paths with the same hash is something like 4.2 billion as is the number of int, so there is an eventual chance of collision. A more surefire method would probably be to add some kind of pathID to the Path class and check against that, but I'm not invested enough to figure that out yet. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BugFix for when the path changes but the coroutine runs until the next yield statement, causing an error to throw when the pathIndex on line 62 is bigger than what the new path's turnBoundaries length. Checking with a hash means that at least most of the time this error doesn't come to pass, and is not resource intensive whatsoever on the method. The possibilities of having two paths with the same hash is something like 4.2 billion as is the number of int, so there is an eventual chance of collision. A more surefire method would probably be to add some kind of pathID to the Path class and check against that, but I'm not invested enough to figure that out yet. :)