fix: support mixed ASC/DESC directions in ORDER BY#5
Merged
Conversation
Replace single reverse flag with per-column comparator using functools.cmp_to_key. Each ORDER BY column now respects its own direction independently. Closes #3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3.
ORDER BYwith mixed ASC/DESC directions (e.g.ORDER BY name ASC, age DESC) now correctly applies each column's direction independently.Root Cause
_execute_order_byused a singlereverseflag for the entiresorted()call, determined by the first ORDER BY column's direction. All columns were sorted in the same direction.Fix
Replaced the single-flag approach with a per-column comparator using
functools.cmp_to_key. Each ORDER BY column now respects its own ASC/DESC direction. NULL handling is preserved (NULLs sort last regardless of direction).Test
Added
test_order_by_mixed_directionsthat sorts byactive DESC, age ASCand verifies both the group ordering and within-group ordering are correct.Verification