Skip to content

Fixed: Exit to vault list on screen lock in photo view#124

Closed
L-Henke wants to merge 1 commit into
SecrecySupportTeam:masterfrom
L-Henke:fixExitOnLock2
Closed

Fixed: Exit to vault list on screen lock in photo view#124
L-Henke wants to merge 1 commit into
SecrecySupportTeam:masterfrom
L-Henke:fixExitOnLock2

Conversation

@L-Henke

@L-Henke L-Henke commented Mar 18, 2015

Copy link
Copy Markdown
Contributor

Maybe this fix works better :)
It was a little confusing that the FilePhotoFragment.java contains an FragmentActivity and a FragmentStatePagerAdapter.

@L-Henke

L-Henke commented Mar 18, 2015

Copy link
Copy Markdown
Contributor Author

In this PR this is to be expected, because it contains the faulty #116, but not the fix #121.

@StelianMorariu

Copy link
Copy Markdown
Contributor

This is still not working for me. I played around with creating a BroadcastReciever to recieve SCREEN_OFF events. The event gets intercepted correctly by the FilesActivity but I can't understand why the photos are still visible (you get an encrypted photo after screen unlock - but the view is still there). Ping me when you have time and I'll send a patch.

@L-Henke

L-Henke commented Mar 20, 2015

Copy link
Copy Markdown
Contributor Author

Without having seen your patch I can only guess. And I would guess: Because the FilesActivity is not the active activity when viewing a picture. It is FilePhotoFragment (which extends a FragmentActivity although the name doesn't really fit). That activity is together with the SamplePagerAdapter in the file FilePhotoFragment.java. That file is another candidate for a little refactorization ;-)

@L-Henke

L-Henke commented Mar 21, 2015

Copy link
Copy Markdown
Contributor Author

A quick test shows, that the broadcast receiver will work in the FilePhotoFragment(Activity) L-Henke@7c13a87

@StelianMorariu

Copy link
Copy Markdown
Contributor

Hmmm, please have a look at #129. I couldn't get the event to reach FilePhotoFragment, even if it did, the photo view would still be visible.

@L-Henke

L-Henke commented Mar 21, 2015

Copy link
Copy Markdown
Contributor Author

Closed, because according to @StelianMorariu this doesn't work reliable.

@L-Henke L-Henke closed this Mar 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants