Gaotax2006 [ Payment ] Fix #1: Integrate Stripe PaymentIntent gateway#536
Closed
Gaotax2006 wants to merge 2 commits into
Closed
Gaotax2006 [ Payment ] Fix #1: Integrate Stripe PaymentIntent gateway#536Gaotax2006 wants to merge 2 commits into
Gaotax2006 wants to merge 2 commits into
Conversation
Replace stub createPaymentIntent with real Stripe SDK integration: - Install stripe npm package - Add Zod schema validation (amount required, positive integer) - Default currency to usd - Return clientSecret and paymentId from Stripe API - Handle Stripe errors with meaningful messages - Add unit tests for validation + smoke test guard
Author
|
Closed by audit (2026-05-24) Issues found:
Please recreate a clean PR containing only the Stripe-related files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1
Replace the stub createPaymentIntent with real Stripe PaymentIntent integration using the stripe npm package.
Files changed
apps/api/src/services/paymentService.jsapps/api/src/validators/paymentValidation.jsapps/api/tests/payment.test.jsapps/api/package.jsonapps/api/package-lock.jsonbenchmarks/results/benchmark-2026-05-17T06-21-20-880Z.mdAcceptance checklist
Audit note (2026-05-24): PR was closed for package-lock.json then reopened. The lockfile change is legitimate (adds stripe dep). The benchmark result file appears incidental; consider removing from this PR.