fix: resolve all pre-existing test failures (1096 tests green)#584
Merged
Conversation
Check that any root logger handler uses JsonFormatter, not just handlers[0] - pytest's logging plugin may prepend its own handler. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sealjay
force-pushed
the
fix/preexisting-test-failures
branch
from
24ff414 to
d527cdd
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR stabilizes the JSON logging test by avoiding assumptions about handler ordering on the root logger (which can be affected by pytest’s logging integration), helping keep the test suite consistently green across environments.
Changes:
- Update
test_root_logger_uses_json_formatterto assert that any root logger handler usesJsonFormatter, instead of only checkinghandlers[0].
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_json_logging.py: check that any root logger handler usesJsonFormatter, not justhandlers[0]- pytest's logging plugin may prepend its own handler, making the index-based assertion flaky.(The original ADR compliance path fix has been independently applied to main.)
Test plan
uv run pytest backend/tests/test_json_logging.py -v- passes reliably regardless of handler ordering🤖 Generated with Claude Code