Remove per-PR Azure environments; production-only deployments#750
Merged
Conversation
The Azure Container Apps deploy workflow still tried to regenerate the frontend SDK with @openapitools/openapi-generator-cli (typescript-axios) into src/api-client/ at build time. That tool needs a JVM that isn't on the runner, and even when it ran it would clobber the committed openapi-fetch client added in #747. Since #747 the api-client (schema.d.ts + client.ts) is committed via the commit-and-verify pipeline, so the build just needs `bun install` plus `bun run build`. Drop the regen and the now-redundant wait-for-backend loop, and use --frozen-lockfile for determinism.
Per-PR environments are no longer wanted — only main deploys. The referenced pr-environments.yml/cleanup-environment.yml workflows don't actually exist in the repo anymore, and deploy-environment.yml's PR-only branches were dead code that could only be triggered by hand. - deploy-environment.yml: drop the is-production input, the PR stack cleanup step, the conditional what-if, the conditional unmanage/deny flags (now always detach + denyDelete), and the pr-* container-app resource-token suffix. - deploy-production.yml: stop passing the now-removed is-production input. - docs/architecture.md: replace the pr-environments.yml description with a note that PR Azure environments are intentionally not provisioned. - ADR-0007 + ADR-0009: amend Status with the 2026-05-03 reversal, preserving the historical body for context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change removes support for per-PR Azure environments and simplifies the deployment pipeline to production-only. The reusable
deploy-environment.ymlworkflow is now exclusively for production deployments, eliminating the complexity of managing temporary cloud resources for every pull request.Key Changes
is-productioninput parameter and all conditional logic that branched between production and PR deploymentsprod.bicepparamanddev.bicepparamwhat-ifpreview (now always runs for production)detachfor unmanaged resources,denyDeletefor deny-settings-mode)frontend/src/api-client/(generated via thecommit-and-verifypipeline)docs/architecture.mdto clarify that only pushes tomaindeploy to Azure; PRs are validated via test workflows alonedeploy-production.yml: Removed theis-production: trueinput when calling the reusable workflowImplementation Details
--frozen-lockfile) and pre-generated OpenAPI client, making builds faster and more deterministichttps://claude.ai/code/session_01GfjckC2AeVywxvEAA4jc4t