forked from johno/ember-linkify
-
Notifications
You must be signed in to change notification settings - Fork 0
Update ember-cli to 3.28.5, make compatible with Ember 4.x #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
36d1d89
ember-cli-update to 3.28.5
Gaurav0 a3d7f86
run npm audit fix
Gaurav0 8f1d48d
npm run lint:fix
Gaurav0 c072ec4
fix template lint
Gaurav0 7998868
add github actions workflow
Gaurav0 c412e72
bump version number
Gaurav0 fb47b34
switch from yarn to npm in github workflow
Gaurav0 aa275cf
update ember-auto-import to v2
Gaurav0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,6 @@ | |
|
|
||
| root = true | ||
|
|
||
|
|
||
| [*] | ||
| end_of_line = lf | ||
| charset = utf-8 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,22 @@ | ||
| /blueprints/*/files/**/*.js | ||
| # unconventional js | ||
| /blueprints/*/files/ | ||
| /vendor/ | ||
|
|
||
| # compiled output | ||
| /dist/ | ||
| /tmp/ | ||
|
|
||
| # dependencies | ||
| /bower_components/ | ||
| /node_modules/ | ||
|
|
||
| # misc | ||
| /coverage/ | ||
| !.* | ||
| .*/ | ||
| .eslintcache | ||
|
|
||
| # ember-try | ||
| /.node_modules.ember-try/ | ||
| /bower.json.ember-try | ||
| /package.json.ember-try |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,50 +1,53 @@ | ||
| 'use strict'; | ||
|
|
||
| module.exports = { | ||
| root: true, | ||
| parser: 'babel-eslint', | ||
| parserOptions: { | ||
| ecmaVersion: 2017, | ||
| sourceType: 'module' | ||
| ecmaVersion: 2018, | ||
| sourceType: 'module', | ||
| ecmaFeatures: { | ||
| legacyDecorators: true, | ||
| }, | ||
| }, | ||
| plugins: [ | ||
| 'ember' | ||
| ], | ||
| plugins: ['ember'], | ||
| extends: [ | ||
| 'eslint:recommended', | ||
| 'plugin:ember/recommended' | ||
| 'plugin:ember/recommended', | ||
| 'plugin:prettier/recommended', | ||
| ], | ||
| env: { | ||
| browser: true | ||
| }, | ||
| rules: { | ||
| browser: true, | ||
| }, | ||
| rules: {}, | ||
| overrides: [ | ||
| // node files | ||
| { | ||
| files: [ | ||
| 'ember-cli-build.js', | ||
| 'index.js', | ||
| 'testem.js', | ||
| 'blueprints/*/index.js', | ||
| 'config/**/*.js', | ||
| 'tests/dummy/config/**/*.js' | ||
| ], | ||
| excludedFiles: [ | ||
| 'addon/**', | ||
| 'addon-test-support/**', | ||
| 'app/**', | ||
| 'tests/dummy/app/**' | ||
| './.eslintrc.js', | ||
| './.prettierrc.js', | ||
| './.template-lintrc.js', | ||
| './ember-cli-build.js', | ||
| './index.js', | ||
| './testem.js', | ||
| './blueprints/*/index.js', | ||
| './config/**/*.js', | ||
| './tests/dummy/config/**/*.js', | ||
| ], | ||
| parserOptions: { | ||
| sourceType: 'script', | ||
| ecmaVersion: 2015 | ||
| }, | ||
| env: { | ||
| browser: false, | ||
| node: true | ||
| node: true, | ||
| }, | ||
| plugins: ['node'], | ||
| rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, { | ||
| // add your custom rules and overrides for node files here | ||
| }) | ||
| } | ||
| ] | ||
| extends: ['plugin:node/recommended'], | ||
| }, | ||
| { | ||
| // Test files: | ||
| files: ['tests/**/*-test.{js,ts}'], | ||
| extends: ['plugin:qunit/recommended'], | ||
| }, | ||
| ], | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| pull_request: {} | ||
|
|
||
| concurrency: | ||
| group: ci-${{ github.head_ref || github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| test: | ||
| name: "Tests" | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 10 | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Install Node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 14.x | ||
| cache: npm | ||
| - name: Install Dependencies | ||
| run: npm install --frozen-lockfile | ||
| - name: Lint | ||
| run: npm run lint | ||
| - name: Run Tests | ||
| run: npm run test:ember | ||
| floating: | ||
| name: "Floating Dependencies" | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 10 | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 14.x | ||
| cache: npm | ||
| - name: Install Dependencies | ||
| run: npm install --no-lockfile | ||
| - name: Run Tests | ||
| run: npm run test:ember | ||
|
|
||
| try-scenarios: | ||
| name: ${{ matrix.try-scenario }} | ||
| runs-on: ubuntu-latest | ||
| needs: "test" | ||
| timeout-minutes: 10 | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| try-scenario: | ||
| - ember-lts-3.24 | ||
| - ember-lts-3.28 | ||
| - ember-lts-4.4 | ||
| - ember-release | ||
| - ember-beta | ||
| - ember-canary | ||
| - ember-default-with-jquery | ||
| - ember-classic | ||
| - embroider-safe | ||
| - embroider-optimized | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Install Node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 14.x | ||
| cache: npm | ||
| - name: Install Dependencies | ||
| run: npm install --frozen-lockfile | ||
| - name: Run Tests | ||
| run: ./node_modules/.bin/ember try:one ${{ matrix.try-scenario }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,26 @@ | ||
| # See https://help.github.com/ignore-files/ for more about ignoring files. | ||
|
|
||
| # compiled output | ||
| /dist | ||
| /tmp | ||
| /dist/ | ||
| /tmp/ | ||
|
|
||
| # dependencies | ||
| /node_modules | ||
| /bower_components | ||
| /bower_components/ | ||
| /node_modules/ | ||
|
|
||
| # misc | ||
| /.env* | ||
| /.pnp* | ||
| /.sass-cache | ||
| /.eslintcache | ||
| /connect.lock | ||
| /coverage/* | ||
| /coverage/ | ||
| /libpeerconnection.log | ||
| npm-debug.log* | ||
| yarn-error.log | ||
| testem.log | ||
| /npm-debug.log* | ||
| /testem.log | ||
| /yarn-error.log | ||
|
|
||
| # ember-try | ||
| .node_modules.ember-try/ | ||
| bower.json.ember-try | ||
| package.json.ember-try | ||
| /.node_modules.ember-try/ | ||
| /bower.json.ember-try | ||
| /package.json.ember-try |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,36 @@ | ||
| /bower_components | ||
| # compiled output | ||
| /dist/ | ||
| /tmp/ | ||
|
|
||
| # dependencies | ||
| /bower_components/ | ||
|
|
||
| # misc | ||
| /.bowerrc | ||
| /.editorconfig | ||
| /.ember-cli | ||
| /.env* | ||
| /.eslintcache | ||
| /.eslintignore | ||
| /.eslintrc.js | ||
| /.git/ | ||
| /.gitignore | ||
| /.prettierignore | ||
| /.prettierrc.js | ||
| /.template-lintrc.js | ||
| /.travis.yml | ||
| /.watchmanconfig | ||
| /bower.json | ||
| /config/ember-try.js | ||
| /dist | ||
| /tests | ||
| /tmp | ||
| **/.gitkeep | ||
| .bowerrc | ||
| .editorconfig | ||
| .ember-cli | ||
| .eslintrc.js | ||
| .gitignore | ||
| .watchmanconfig | ||
| .travis.yml | ||
| bower.json | ||
| ember-cli-build.js | ||
| testem.js | ||
| /CONTRIBUTING.md | ||
| /ember-cli-build.js | ||
| /testem.js | ||
| /tests/ | ||
| /yarn-error.log | ||
| /yarn.lock | ||
| .gitkeep | ||
|
|
||
| # ember-try | ||
| .node_modules.ember-try/ | ||
| bower.json.ember-try | ||
| package.json.ember-try | ||
| /.node_modules.ember-try/ | ||
| /bower.json.ember-try | ||
| /package.json.ember-try |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # unconventional js | ||
| /blueprints/*/files/ | ||
| /vendor/ | ||
|
|
||
| # compiled output | ||
| /dist/ | ||
| /tmp/ | ||
|
|
||
| # dependencies | ||
| /bower_components/ | ||
| /node_modules/ | ||
|
|
||
| # misc | ||
| /coverage/ | ||
| !.* | ||
| .eslintcache | ||
|
|
||
| # ember-try | ||
| /.node_modules.ember-try/ | ||
| /bower.json.ember-try | ||
| /package.json.ember-try |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| 'use strict'; | ||
|
|
||
| module.exports = { | ||
| singleQuote: true, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| 'use strict'; | ||
|
|
||
| module.exports = { | ||
| extends: 'recommended', | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Nice catch!