Skip to content

fix(compare-per-dollar): clearer axis labels and curve-extension distinction in PNG #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Oseltamivir merged 8 commits into from
May 27, 2026
Merged

fix(compare-per-dollar): clearer axis labels and curve-extension distinction in PNG #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2b2081c
fix(compare-per-dollar): clearer axis labels and curve-extension dist…
Oseltamivir May 27, 2026
5fc5c04
fix(compare-per-dollar): render PNG natively at 2400x1350 for sharp g…
Oseltamivir May 27, 2026
43fdcc9
fix(compare): use Thing instead of Product in JSON-LD
Oseltamivir May 27, 2026
d616c5c
fix(compare): switch row entries to Dataset so Dataset.hasPart validates
Oseltamivir May 27, 2026
4b6b0ce
fix(compare): add license and creator to Dataset JSON-LD
Oseltamivir May 27, 2026
28fb15b
Merge branch 'master' into fix/per-dollar-png-axis-and-extension
Oseltamivir May 27, 2026
ac9b5d7
feat(compare): enrich JSON-LD for Google Dataset Search and add bread…
Oseltamivir May 27, 2026
f501dbb
fix(compare): dedup keywords so same-vendor pairs don't repeat vendor…
Oseltamivir May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/app/src/app/compare-per-dollar/[slug]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,11 @@ import {
import { getAllComparableCompareSlugs } from '@/lib/compare-availability';
import { getGpuSpecs } from '@/lib/constants';
import {
buildBreadcrumbJsonLd,
buildJsonLd,
compareTableNarrative,
computeCompareTableData,
dateRangeForPair,
getCachedBenchmarks,
KNOWN_MODELS,
KNOWN_PRECISIONS,
Expand Down Expand Up @@ -121,6 +123,7 @@ export default async function ComparePerDollarPage({ params, searchParams }: Pro

const url = `${SITE_URL}/compare-per-dollar/${canonical}`;
const imageUrl = `${url}/performance-per-dollar.png`;
const { oldest, newest } = dateRangeForPair(rows, parsed.a, parsed.b);
const jsonLd = buildJsonLd(
'per-dollar',
parsed.model,
Expand All @@ -131,6 +134,14 @@ export default async function ComparePerDollarPage({ params, searchParams }: Pro
summaryB,
ssrRows,
imageUrl,
oldest,
newest,
parsed.model.displayName,
);
const breadcrumbJsonLd = buildBreadcrumbJsonLd(
'per-dollar',
compareModelDisplayLabel(parsed.model, parsed.a, parsed.b),
url,
);
const label = compareModelDisplayLabel(parsed.model, parsed.a, parsed.b);
const aMeta = HW_REGISTRY[parsed.a];
Expand All @@ -155,6 +166,7 @@ export default async function ComparePerDollarPage({ params, searchParams }: Pro
return (
<>
<JsonLd data={jsonLd} />
<JsonLd data={breadcrumbJsonLd} />
<ComparePerDollarPageClient
a={parsed.a}
b={parsed.b}
Expand Down
Loading
Loading