-
Notifications
You must be signed in to change notification settings - Fork 190
[Fix] Remove MoRI-IO patches from vLLM Disagg benchmarks #1585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
simondanielsson
wants to merge
8
commits into
main
Choose a base branch
from
fix/remove-vllm-disagg-patches
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
89b9243
fix: remove moriio connector patches after bumping to new nightly vll…
simondanielsson d2aadee
fix: move read mode envvar to flag
simondanielsson 24555d3
fix: unpin vllm-router image
simondanielsson dfdbc7d
fix: update to mori_low_latency backend after rename in nightly
simondanielsson 0c16e44
fix: pin nightlyies
simondanielsson 3c94a6f
fix: comments and add perf-changelog.yml
simondanielsson 3412624
Merge remote-tracking branch 'upstream' into fix/remove-vllm-disagg-p…
simondanielsson f3b4132
fix: pint router iamge as well
simondanielsson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1524,7 +1524,9 @@ dsr1-fp8-mi355x-sglang-disagg-mtp: | |
| - "DECODE_MTP_SIZE=2" | ||
|
|
||
| kimik2.5-fp4-mi355x-vllm-disagg: | ||
| image: vllm/vllm-openai-rocm:nightly-bf610c2f56764e1b30bc6065f4ceace3d6e59036 | ||
| # TODO(simondanielsson): change to pinned version once https://github.com/vllm-project/vllm/pull/40344 | ||
| # is part of official release, likely 0.22.0. | ||
| image: vllm/vllm-openai-rocm:nightly-3f0a91bb96f8d72e0498b95c166e817deae14d62 | ||
| model: amd/Kimi-K2.5-MXFP4 | ||
| model-prefix: kimik2.5 | ||
| runner: mi355x-disagg | ||
|
simondanielsson marked this conversation as resolved.
|
||
|
|
@@ -1547,7 +1549,6 @@ kimik2.5-fp4-mi355x-vllm-disagg: | |
| dp-attn: false | ||
| additional-settings: | ||
| - "PREFILL_NODES=1" | ||
| - "VLLM_MORIIO_CONNECTOR_READ_MODE=1" | ||
| decode: | ||
| num-worker: 2 | ||
| tp: 8 | ||
|
|
@@ -1568,7 +1569,6 @@ kimik2.5-fp4-mi355x-vllm-disagg: | |
| dp-attn: false | ||
| additional-settings: | ||
| - "PREFILL_NODES=1" | ||
| - "VLLM_MORIIO_CONNECTOR_READ_MODE=1" | ||
| decode: | ||
| num-worker: 2 | ||
| tp: 8 | ||
|
|
@@ -1578,7 +1578,9 @@ kimik2.5-fp4-mi355x-vllm-disagg: | |
| - "DECODE_NODES=2" | ||
|
|
||
| minimaxm2.5-fp8-mi355x-vllm-disagg: | ||
| image: vllm/vllm-openai-rocm:nightly-a6682d1d259cca69a9ae737ea5608fbbe7520031 | ||
| # TODO(simondanielsson): change to pinned version once https://github.com/vllm-project/vllm/pull/40344 | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can u have an specific night hash pinned here here instead of just the generic "nightly" |
||
| # is part of official release, likely 0.22.0. | ||
| image: vllm/vllm-openai-rocm:nightly-3f0a91bb96f8d72e0498b95c166e817deae14d62 | ||
| model: MiniMaxAI/MiniMax-M2.5 | ||
| model-prefix: minimaxm2.5 | ||
| runner: mi355x-disagg | ||
|
|
@@ -1603,7 +1605,6 @@ minimaxm2.5-fp8-mi355x-vllm-disagg: | |
| dp-attn: false | ||
| additional-settings: | ||
| - "PREFILL_NODES=1" | ||
| - "VLLM_MORIIO_CONNECTOR_READ_MODE=1" | ||
| decode: | ||
| num-worker: 2 | ||
| tp: 8 | ||
|
|
@@ -1624,7 +1625,6 @@ minimaxm2.5-fp8-mi355x-vllm-disagg: | |
| dp-attn: false | ||
| additional-settings: | ||
| - "PREFILL_NODES=1" | ||
| - "VLLM_MORIIO_CONNECTOR_READ_MODE=1" | ||
| decode: | ||
| num-worker: 2 | ||
| tp: 8 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.