π¨ Palette: Improve accessibility for icon-only buttons#64
π¨ Palette: Improve accessibility for icon-only buttons#64saynchowdhury wants to merge 1 commit into
Conversation
- Add `aria-label` and `aria-expanded` to mobile menu toggle in Header - Add `aria-label` to SearchInput clear button - Add `aria-label` to MoreFiltersSheet close button Co-authored-by: saynchowdhury <205922286+saynchowdhury@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the βοΈ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
β¨ Finishing Touchesπ§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
π‘ What: Added ARIA labels and state attributes to icon-only buttons in the Header, SearchInput, and MoreFiltersSheet.
π― Why: Enhances the experience for screen reader users who previously might not have known the purpose or state of these interactive elements.
βΏ Accessibility:
aria-labelandaria-expandedto the mobile menu toggle inHeader.tsx.aria-label="Clear search"to the clear button inSearchInput.tsx.aria-label="Close filters"to the close button inMoreFiltersSheet.tsx.PR created automatically by Jules for task 16894294362617947633 started by @saynchowdhury