🛡️ Sentinel: [HIGH] Fix XSS vulnerability in JSON-LD script tags#67
🛡️ Sentinel: [HIGH] Fix XSS vulnerability in JSON-LD script tags#67saynchowdhury wants to merge 1 commit into
Conversation
💡 Vulnerability: Directly embedding `JSON.stringify()` output into `dangerouslySetInnerHTML` within script tags for JSON-LD allowed for potential script breakout attacks. 🎯 Impact: An attacker could inject malicious scripts if they could control any data field included in the structured data (e.g., via scraped content or future user-generated content). 🔧 Fix: Implemented `safeJsonLd` utility in `lib/utils.ts` to escape `<` and `>` characters and applied it to all JSON-LD script tags. ✅ Verification: Verified via a test script that characters are correctly escaped and performed manual inspection of rendered DOM. Co-authored-by: saynchowdhury <205922286+saynchowdhury@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
1 participant
This PR addresses a Cross-Site Scripting (XSS) vulnerability found in the handling of JSON-LD structured data.
Changes:
safeJsonLdutility inlib/utils.tswhich safely stringifies objects and escapes<and>characters to\u003cand\u003e.app/layout.tsx,app/opportunity/[id]/page.tsx,app/blog/page.tsx, andapp/blog/[slug]/page.tsxto usesafeJsonLdfor all JSON-LD script tags..jules/sentinel.md.Security Impact:
Prevents "script breakout" attacks where malicious data could terminate the JSON block and execute arbitrary JavaScript.
Verification:
pnpm lintandpnpm test:run(all passed).safeJsonLdescaping with a standalone script.PR created automatically by Jules for task 10415949350961015125 started by @saynchowdhury