Fix FlexiGrid reactive loops and ProcessConfig warnings#127
Conversation
- Implemented stable row identity in `FlexiGrid.vue` to prevent redundant DOM unmounting. - Added gated content updates in `FlexValueControl.vue` to stabilize Tiptap editor state. - Refactored `ProcessConfig.vue` to safely handle async initialization and reduce log noise. - Fixes "Node cannot be found in the current page" and "Process name or operation missing" errors.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
- Implemented stable row identity in `FlexiGrid.vue` to prevent redundant DOM unmounting and focus loss. - Added gated content updates in `FlexValueControl.vue` to stabilize Tiptap editor state and prevent "Node cannot be found" errors. - Refactored `ProcessConfig.vue` to safely handle async initialization and fixed linter formatting. - Updated `deduplication.json` with missing `fields_config` child table schema to fix empty grid rendering. - Standardized formatting across several files to ensure CI compliance.
|
it still never fix the Process Config child table |
- Refactored `AssignmentConfig.vue` to use `FlexiGrid` for managing assignments. - Reordered columns to: Run If, Target Field, Operator, Value Expression. - Added `Button` fieldtype support to `ControlFactory.vue`. - Enhanced `FlexiGrid.vue` to emit `cell-click` events. - Preserved dynamic logic for operator filtering and structured value context. - Fixed linting issues and removed redundant row management code.
2 participants
This PR addresses critical stability issues in the FlexiRule Rule Builder UI, specifically when configuring processes with child tables.
Changes:
modelValuewatcher now preserves object references for existing rows (matched byname). This prevents Vue from destroying and recreating every cell component on every change, which was causing the "Node cannot be found" error and breaking focus.FlexValueControl.vueto only update the Tiptap editor if the content has actually changed. This prevents cursor jumping and unnecessary re-render cycles.process_nameandoperationinProcessConfig.vueto suppress premature warnings during the asynchronous hydration phase of the rule builder.toRawfor cleaner console logging of reactive proxies.PR created automatically by Jules for task 13020262370328003070 started by @abdoruzaqi