Open
Conversation
PhilZ-cwm6
commented
May 27, 2022
PhilZ-cwm6
commented
- Upgrade jcifs-ng to 2.1.7
- Recompile smb v1 jcifs to use jcifs13 class
- For simpler maintenance, upgrade latest jcifs-ng class to jcifs
- Upgrade jcifs-ng to 2.1.7 - Recompile smb v1 jcifs to use jcifs13 class - For simpler maintenance, upgrade latest jcifs-ng class to jcifs
Author
For simpler maintenance, I renamed the jcifs-ng latest class as in main sources, that is jcifs In the future, updating jcifs is a matter of compiling original source with small changes to fix compiler issues. Major changes are only needed if you want to change the latest 2.14 for example to 2.16... Edit: note that I had to revert the upgrade of bouncycastle fix. It will need to be first added to eclipse dependencies to fix compiler errors. However, for 2.1.7, it has no impact on current code. |
this upgrades jcifs-ng lib to match upstream source logging code using braces formatting
Update jcifs-ng with bouncycastle.org bcprov-jdk15to18-169 (only upstream source changes, compiled code is the same)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.