Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CSV Panic in parse_csv VRL Function
Problem
The
quick-csvlibrary panics when parsing CSV data with a lone quote at the end of a line, causing Vector to crash when processing malformed CSV files.Panic location:
quick-csv-0.1.6/src/columns.rs:25:44Root Cause
In
quick-csv, when iterating columns viabytes_columns(), the code attempts to strip quotes from quoted fields:Changes
src/stdlib/parse_csv.rs: Added ends_with_lone_quote() function and validation check before CSV parsing
Tests Added
lone_quote_at_end - a,"
just_a_quote - "
empty_field_then_lone_quote - ,"