CI: Don't use timestamps as cache keys for TimeZone and Unicode caches #26468
+3
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since e5f3615 we included a timestamp in these cache keys. But doing so should be unnecessary, since hashing the respective CMake scripts should be enough as they already include the expected SHA256 hashes of the files to download. This should cause less duplicate caches, since we now get exact matches of the cache key instead of falling back to the restore key. If no exact cache key match was found, GitHub actions creates a new cache.
github-actions
bot
added
the
👀 pr-needs-review
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since e5f3615 we included a timestamp in these cache keys. But doing so should be unnecessary, since hashing the respective CMake scripts should be enough as they already include the expected SHA256 hashes of the files to download.
This should cause less duplicate caches, since we now get exact matches of the cache key instead of falling back to the restore key. If no exact cache key match was found, GitHub actions creates a new cache.