Fix macos build failure#77
Conversation
Agent-Logs-Url: https://github.com/audiohacking/acestep.cpp/sessions/3822a733-dbac-4964-8207-6418ecc203d9 Co-authored-by: lmangani <1423657+lmangani@users.noreply.github.com>
…it-graph.h Agent-Logs-Url: https://github.com/audiohacking/acestep.cpp/sessions/b1a4e02e-b7cf-4128-ac70-fd9acd368334 Co-authored-by: lmangani <1423657+lmangani@users.noreply.github.com>
Signed-off-by: Lorenzo Mangani <lorenzo.mangani@gmail.com>
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR contains two independent changes: disabling the GitHub Actions ChangesCI Workflow
CSV Parser Refactoring
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/pipeline-synth-ops.cpp`:
- Around line 53-74: parse_csv_float currently uses std::strtof which is
LC_NUMERIC dependent; update parse_csv_float to parse each numeric token in a C
locale to be locale-independent (e.g., create an std::istringstream for the
token, call ss.imbue(std::locale::classic() or std::locale("C")), then extract a
float via operator>> and check for stream errors) instead of calling
std::strtof; ensure you handle tokens that fail to parse by skipping/breaking
the loop as before and reference parse_csv_float when making the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: cfc2542b-47d7-4a32-9ba6-8d1749ca7e95
📒 Files selected for processing (2)
.github/workflows/ci-build.ymlsrc/pipeline-synth-ops.cpp
…tream + C locale) (#30) * Make parse_csv_float locale-independent using std::istringstream with C locale Agent-Logs-Url: https://github.com/audiohacking/acestep.cpp/sessions/2329eeb3-4e21-4d6b-8232-3e78627581e0 Co-authored-by: lmangani <1423657+lmangani@users.noreply.github.com> * Reuse string buffer across iterations and validate full token consumption with ss.eof() Agent-Logs-Url: https://github.com/audiohacking/acestep.cpp/sessions/2329eeb3-4e21-4d6b-8232-3e78627581e0 Co-authored-by: lmangani <1423657+lmangani@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lmangani <1423657+lmangani@users.noreply.github.com>
|
Thanks for the report and the macOS testing! I ended up going with a unified alternative on master: parse_csv stays as a single template, with a scan_num helper that overloads on int and float. The float overload uses std::from_chars normally and only falls back to a tiny hand rolled C locale parser when _LIBCPP_VERSION < 200000 (AppleClang). Mainline path stays byte identical on Linux and Windows, zero allocation everywhere. |
Uh oh!
There was an error while loading. Please reload this page.