Skip to content

Fix macos build failure#77

Closed
lmangani wants to merge 6 commits into
ServeurpersoCom:masterfrom
audiohacking:fix-macos-build-failure
Closed

Fix macos build failure#77
lmangani wants to merge 6 commits into
ServeurpersoCom:masterfrom
audiohacking:fix-macos-build-failure

Conversation

@lmangani

@lmangani lmangani commented May 16, 2026

Copy link
Copy Markdown
Contributor
  • MacOS: Fix std::from_chars with floats is unsupported with AppleClang 15
  • Actions: Suspend GH CI linter step due to excessive exceptions and consistent failures

@coderabbitai

coderabbitai Bot commented May 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@lmangani has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 36 minutes and 32 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bae3df5e-3188-480a-9cfd-1a6f5969813c

📥 Commits

Reviewing files that changed from the base of the PR and between 89a387f and 2f5635f.

📒 Files selected for processing (1)
  • src/pipeline-synth-ops.cpp
📝 Walkthrough

Walkthrough

This PR contains two independent changes: disabling the GitHub Actions lint job via conditional configuration, and refactoring CSV parsing logic in the C++ pipeline code by replacing a generic template with two dedicated parsers for integer and float values.

Changes

CI Workflow

Layer / File(s) Summary
Disable lint job
.github/workflows/ci-build.yml
Job-level condition changed to if: false to prevent automated linting from running on pull requests.

CSV Parser Refactoring

Layer / File(s) Summary
Parser implementations
src/pipeline-synth-ops.cpp
Add <cerrno> header and implement two whitespace-tolerant dedicated CSV parsers: parse_csv_int using std::from_chars for locale-immune integer parsing, and parse_csv_float using std::strtof with errno-based overflow detection.
Integration with call sites
src/pipeline-synth-ops.cpp
Update ops_resolve_params and ops_build_schedule functions to use the new parse_csv_int and parse_csv_float parsers instead of the generic parse_csv<T> template.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 Two parsers hop where templates used to dwell,
With from_chars and strtof, no rounding bell,
The lint job sleeps with if: false so clear,
Whitespace-tolerant, robust and sincere! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly addresses the primary change: fixing macOS build issues by replacing a templated CSV parser with platform-specific implementations and disabling the CI lint job.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/pipeline-synth-ops.cpp`:
- Around line 53-74: parse_csv_float currently uses std::strtof which is
LC_NUMERIC dependent; update parse_csv_float to parse each numeric token in a C
locale to be locale-independent (e.g., create an std::istringstream for the
token, call ss.imbue(std::locale::classic() or std::locale("C")), then extract a
float via operator>> and check for stream errors) instead of calling
std::strtof; ensure you handle tokens that fail to parse by skipping/breaking
the loop as before and reference parse_csv_float when making the change.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cfc2542b-47d7-4a32-9ba6-8d1749ca7e95

📥 Commits

Reviewing files that changed from the base of the PR and between 35067e5 and 89a387f.

📒 Files selected for processing (2)
  • .github/workflows/ci-build.yml
  • src/pipeline-synth-ops.cpp

Comment thread src/pipeline-synth-ops.cpp
…tream + C locale) (#30)

* Make parse_csv_float locale-independent using std::istringstream with C locale

Agent-Logs-Url: https://github.com/audiohacking/acestep.cpp/sessions/2329eeb3-4e21-4d6b-8232-3e78627581e0

Co-authored-by: lmangani <1423657+lmangani@users.noreply.github.com>

* Reuse string buffer across iterations and validate full token consumption with ss.eof()

Agent-Logs-Url: https://github.com/audiohacking/acestep.cpp/sessions/2329eeb3-4e21-4d6b-8232-3e78627581e0

Co-authored-by: lmangani <1423657+lmangani@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: lmangani <1423657+lmangani@users.noreply.github.com>
@lmangani lmangani closed this May 16, 2026
@ServeurpersoCom

Copy link
Copy Markdown
Owner

Thanks for the report and the macOS testing!

I ended up going with a unified alternative on master: parse_csv stays as a single template, with a scan_num helper that overloads on int and float. The float overload uses std::from_chars normally and only falls back to a tiny hand rolled C locale parser when _LIBCPP_VERSION < 200000 (AppleClang). Mainline path stays byte identical on Linux and Windows, zero allocation everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants