Skip to content

Browser fix - #245

Merged
ollmer merged 5 commits into
mainfrom
browser_fix
Oct 14, 2025
Merged

ollmer merged 5 commits into
mainfrom
browser_fix

Conversation

@ollmer

@ollmer ollmer commented Oct 14, 2025

Copy link
Copy Markdown
Contributor
  1. fix browser context existence check
  2. better loop logging
  3. fix tool descriptions as actions() already provides classes not objects
  4. import docling DL models only when used to avoid issues whe running without gpu

Description by Korbit AI

What change is being made?

  • Fix action description formatting by using action names instead of class names in tools_description.
  • Add a per-loop unique identifier (loop_id) for log messages and update log output to reference the loop instead of the tape turn.
  • Improve browser resource teardown by ensuring the browser context is non-null before closing.
  • Adjust docling converters to lazy-import dependencies, moving certain imports inside methods to avoid early import-time side effects and potential circular imports.

Why are these changes being made?

Improve log clarity and reliability during multi-loop runs, ensure proper browser shutdown without risking null context access, and reduce import-time coupling in converters for safer, more maintainable initialization.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

@ollmer
ollmer requested a review from rafapi October 14, 2025 15:13

@korbit-ai korbit-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.
Category Issue Status
Logging Insufficient detail in agent step logging ▹ view
Performance Repeated import in method execution ▹ view
Files scanned
File Path Reviewed
tapeagents/environment.py
tapeagents/orchestrator.py
tapeagents/tools/converters.py
tapeagents/tools/browser.py

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

Comment thread tapeagents/orchestrator.py
Comment thread tapeagents/tools/converters.py

@rafapi rafapi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ollmer
ollmer merged commit e22d5e3 into main Oct 14, 2025
5 checks passed
@ollmer
ollmer deleted the browser_fix branch October 14, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants